Skip to content

Commit a31dccd

Browse files
committed
Help on setting up development added
1 parent 4066e83 commit a31dccd

File tree

3 files changed

+34
-20
lines changed

3 files changed

+34
-20
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ Repo-level stuff:
4747
[#1200](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1200),
4848
[#1201](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1201)
4949
[@jcb91](https://github.com/jcb91)
50+
- Added CONTRIBUTION.md
51+
[#1224](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1224)
52+
[@consideratio](https://github.com/consideratio)
5053

5154
New features and bugfixes:
5255

CONTRIBUTING.md

Lines changed: 30 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,38 @@
1-
**Hello and welcome to the contribution page of jupyter notebook nbextensions!**
1+
# Contributing to jupyter notebook nbextensions
22

3-
We are super happy that you intend to contribute to the nbextensions. Here is the plan how this works very nicely, for you and of course for the repository maintainer too.
3+
We are super happy that you intend to contribute to the nbextensions! You can discuss improvements in issues and improvement them in pull requests.
44

5-
### Create an issue
5+
## Create an issue
66

7-
Do not hesitate to open up an issue to propose your new extension and how you would think of it to work. Like that, it is easier to point you to extensions that do similar things, whether it is worth it to implement this, what to look for etc.
7+
Do not hesitate to open up an issue, you can discuss bugs, improvements or new extensions in them. Creating an issue is a good starting point for code contributions. The community can support you with experience of similar extensions, pros and cons, what to look for etc.
88

9-
Here is an example issue of how @benelot did it and it worked pretty smoothly: [#1193](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/issues/1193)
9+
Here is an example issue of how @benelot did it that worked pretty smoothly: [#1193](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/issues/1193)
1010

11-
To create a new jupyter notebook extension, just fork the repository and clone it to your local machine. Then look into the [jupyter_contrib_nbextensions/nbextensions](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/tree/master/src/jupyter_contrib_nbextensions/nbextensions) folder and add a folder with the name of your new extension. Check out the [Jupyter Notebook extension structure Link](http://jupyter-contrib-nbextensions.readthedocs.io/en/latest/internals.html)k to know what else has to be in that folder and what are the general conventions for it.
11+
## Setup development
1212

13-
### Create a pull request
14-
Then, as you are ready with your contribution, pull-request to the main repo and explain quickly what you have done.
13+
1. __Fork and clone__
14+
First fork this repo, then clone your fork. In this way you become prepared to make a pull request.
1515

16-
Here is an example pull request of how @benelot did it and it worked super well: [#1213](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1213)
16+
```shell
17+
# clone your fork
18+
git clone https://github.com/<your-github-username>/jupyter_contrib_nbextensions.git
19+
cd jupyter_contrib_nbextensions
20+
```
21+
2. __Setup__
22+
```shell
23+
# run from the main directory, where setup.py is
24+
pip install --editable .
25+
jupyter-contrib-nbextension install --symlink --sys-prefix
26+
```
1727

18-
Do not forget to add your new extension to the [CHANGELOG.md](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/blob/master/CHANGELOG.md) so that it will be announced to be in the release.
28+
## Create an extension
29+
30+
Add a folder with the name of your new extension to [jupyter_contrib_nbextensions/nbextensions](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/tree/master/src/jupyter_contrib_nbextensions/nbextensions). Check out the [Jupyter Notebook extension structure link](http://jupyter-contrib-nbextensions.readthedocs.io/en/latest/internals.html) to know what has to be in that folder and what the general conventions are.
31+
32+
## Create a pull request
33+
34+
As you are ready with your code contribution, make a pull-request to the main repo and briefly explain what you have done.
35+
36+
Here is an example pull request of how @benelot did it that worked super well: [#1213](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1213)
37+
38+
Please also update the [CHANGELOG.md](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/blob/master/CHANGELOG.md).

README.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -246,16 +246,7 @@ For further details, see [the documentation at jupyter-contrib-nbextensions.read
246246
Contributing
247247
============
248248

249-
1. __Fork__
250-
2. __Clone and setup__
251-
```bash
252-
git clone https://github.com/ipython-contrib/jupyter_contrib_nbextensions.git
253-
cd jupyter_contrib_nbextensions
254-
pip install --editable .
255-
jupyter-contrib-nbextension install --symlink --sys-prefix
256-
```
257-
3. __Develop__
258-
4. __Pull request__
249+
To learn how to setup a development enivornment and contribution guidelines, see [CONTRIBUTING.md](./CONTRIBUTING.md).
259250

260251
Changes
261252
=======

0 commit comments

Comments
 (0)