Skip to content

Commit b77e03b

Browse files
committed
[exercies,exercise2] don't use rubberband
multi-cell selection is available in 4.0+, so we can safely drop the rubberband for those not already using it
1 parent 182a0c5 commit b77e03b

File tree

2 files changed

+2
-15
lines changed
  • src/jupyter_contrib_nbextensions/nbextensions

2 files changed

+2
-15
lines changed

src/jupyter_contrib_nbextensions/nbextensions/exercise/main.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ define([
2727
'jquery',
2828
'require',
2929
'base/js/events',
30-
'nbextensions/rubberband/main'
31-
], function(IPython, $, requirejs, events, rubberband) {
30+
], function(IPython, $, requirejs, events) {
3231
"use strict";
3332

3433
/**
@@ -159,8 +158,6 @@ function load_ipython_extension(){
159158
};
160159

161160
load_css('./main.css');
162-
var exercise_wrapper = $('<div id="dragmask" class="highlight-drag"></div>');
163-
$("#header").append(exercise_wrapper);
164161

165162
// ***************** Keyboard shortcuts ******************************
166163
var add_cmd_shortcuts = {
@@ -198,8 +195,6 @@ function load_ipython_extension(){
198195
}
199196
}
200197

201-
console.log("Executing rubberband load_ipython")
202-
rubberband.load_ipython_extension();
203198
}
204199

205200

src/jupyter_contrib_nbextensions/nbextensions/exercise2/main.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ define([
4646
'jquery',
4747
'require',
4848
'base/js/events',
49-
'nbextensions/rubberband/main'
50-
], function(IPython, $, requirejs, events, rubberband) {
49+
], function(IPython, $, requirejs, events) {
5150
"use strict";
5251

5352
var cbx=0;
@@ -156,8 +155,6 @@ function load_ipython_extension(){
156155
};
157156

158157
load_css('./main.css');
159-
var exercise_wrapper = $('<div id="dragmask" class="highlight-drag"></div>');
160-
$("#header").append(exercise_wrapper);
161158

162159
/**
163160
* Display existing solutions at startup
@@ -200,14 +197,9 @@ var add_cmd_shortcuts = {
200197
}
201198
IPython.keyboard_manager.command_shortcuts.add_shortcuts(add_cmd_shortcuts);
202199

203-
204-
console.log("Executing rubberband load_ipython")
205-
rubberband.load_ipython_extension();
206200
}
207201

208-
209202
return {
210203
load_ipython_extension: load_ipython_extension,
211204
};
212-
213205
});

0 commit comments

Comments
 (0)