Skip to content

Commit 07da04e

Browse files
committed
clarifying comments/docstrings
1 parent e1cb425 commit 07da04e

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

ipykernel/ipkernel.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,11 @@ def set_parent(self, ident, parent):
124124
def init_metadata(self, parent):
125125
"""Initialize metadata.
126126
127-
Run at the beginning of request handlers.
127+
Run at the beginning of each execution request.
128128
"""
129129
md = super(IPythonKernel, self).init_metadata(parent)
130-
# FIXME: remove ipyparallel-specific code
130+
# FIXME: remove deprecated ipyparallel-specific code
131+
# This is required for ipyparallel < 5.0
131132
md.update({
132133
'dependencies_met' : True,
133134
'engine' : self.ident,
@@ -137,9 +138,10 @@ def init_metadata(self, parent):
137138
def finish_metadata(self, parent, metadata, reply_content):
138139
"""Finish populating metadata.
139140
140-
Run after completing a request handler.
141+
Run after completing an execution request.
141142
"""
142-
# FIXME: remove ipyparallel-specific code:
143+
# FIXME: remove deprecated ipyparallel-specific code
144+
# This is required by ipyparallel < 5.0
143145
metadata['status'] = reply_content['status']
144146
if reply_content['status'] == 'error' and reply_content['ename'] == 'UnmetDependency':
145147
metadata['dependencies_met'] = False

ipykernel/kernelbase.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ def send_response(self, stream, msg_or_type, content=None, ident=None,
348348
def init_metadata(self, parent):
349349
"""Initialize metadata.
350350
351-
Run at the beginning of request handlers.
351+
Run at the beginning of execution requests.
352352
"""
353353
return {
354354
'started': datetime.now(),
@@ -357,7 +357,7 @@ def init_metadata(self, parent):
357357
def finish_metadata(self, parent, metadata, reply_content):
358358
"""Finish populating metadata.
359359
360-
Run after completing a request handler.
360+
Run after completing an execution request.
361361
"""
362362
return metadata
363363

0 commit comments

Comments
 (0)