Skip to content

Commit 083458e

Browse files
committed
Add ForkReply
1 parent 03a29e4 commit 083458e

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

ipykernel/kernelbase.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def post_fork_callback(pid, conn):
171171
metadata = {}
172172
metadata = self.finish_metadata(parent, metadata, reply_content)
173173

174-
self.session.send(stream, u'execute_reply',
174+
self.session.send(stream, u'fork_reply',
175175
reply_content, parent, metadata=metadata,
176176
ident=ident)
177177

ipykernel/tests/test_kernel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ def test_fork_metadata():
333333
km = kc.parent
334334
fork_msg_id = kc.fork()
335335
fork_reply = kc.get_shell_msg(block=True, timeout=TIMEOUT)
336-
# validate_message(fork_reply, "execute_reply", fork_msg_id) # TODO: Make it work (need the `fork_reply`)
336+
validate_message(fork_reply, "fork_reply", fork_msg_id)
337337
assert fork_msg_id == fork_reply['parent_header']['msg_id'] == fork_msg_id
338338
assert fork_reply['content']['conn']['key'] != kc.session.key.decode()
339339
fork_pid = fork_reply['content']['pid']

ipykernel/tests/test_message_spec.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,11 @@ class IsCompleteReplyIncomplete(Reference):
195195
indent = Unicode()
196196

197197

198+
class ForkReply(Reply):
199+
pid = Integer()
200+
conn = Dict()
201+
202+
198203
# IOPub messages
199204

200205
class ExecuteInput(Reference):
@@ -240,6 +245,7 @@ class HistoryReply(Reply):
240245
'stream' : Stream(),
241246
'display_data' : DisplayData(),
242247
'header' : RHeader(),
248+
'fork_reply' : ForkReply(),
243249
}
244250
"""
245251
Specifications of `content` part of the reply messages.

0 commit comments

Comments
 (0)