Delete always skipped tests that used removed attributes.

There are few chances we will ever use them again.

Author: Carreau

tests/test_ipkernel_direct.py

@@ -152,49 +152,12 @@ async def test_direct_clear(ipkernel):
     ipkernel.do_clear()
 
 
-@pytest.mark.skip("ipykernel._cancel_on_sigint doesn't exist anymore")
-async def test_cancel_on_sigint(ipkernel: IPythonKernel) -> None:
-    future: asyncio.Future = asyncio.Future()
-    # with ipkernel._cancel_on_sigint(future):
-    #     pass
-    future.set_result(None)
-
-
 async def test_dispatch_debugpy(ipkernel: IPythonKernel) -> None:
     msg = ipkernel.session.msg("debug_request", {})
     msg_list = ipkernel.session.serialize(msg)
     await ipkernel.receive_debugpy_message(msg_list)
 
 
-@pytest.mark.skip("Queues don't exist anymore")
-async def test_start(ipkernel: IPythonKernel) -> None:
-    shell_future: asyncio.Future = asyncio.Future()
-
-    async def fake_dispatch_queue():
-        shell_future.set_result(None)
-
-    ipkernel.dispatch_queue = fake_dispatch_queue  # type:ignore
-    ipkernel.start()
-    ipkernel.debugpy_stream = None
-    ipkernel.start()
-    await ipkernel.process_one(False)
-    await shell_future
-
-
-@pytest.mark.skip("Queues don't exist anymore")
-async def test_start_no_debugpy(ipkernel: IPythonKernel) -> None:
-    shell_future: asyncio.Future = asyncio.Future()
-
-    async def fake_dispatch_queue():
-        shell_future.set_result(None)
-
-    ipkernel.dispatch_queue = fake_dispatch_queue  # type:ignore
-    ipkernel.debugpy_stream = None
-    ipkernel.start()
-
-    await shell_future
-
-
 def test_create_comm():
     assert isinstance(_create_comm(), BaseComm)
 

tests/test_kernel_direct.py

@@ -108,19 +108,6 @@ async def test_direct_debug_request(kernel):
     assert reply["header"]["msg_type"] == "debug_reply"
 
 
-@pytest.mark.skip("Shell streams don't exist anymore")
-async def test_deprecated_features(kernel):
-    with warnings.catch_warnings():
-        warnings.simplefilter("ignore", DeprecationWarning)
-        header = kernel._parent_header
-        assert isinstance(header, dict)
-        shell_streams = kernel.shell_streams
-        assert len(shell_streams) == 1
-        assert shell_streams[0] == kernel.shell_stream
-        warnings.simplefilter("ignore", RuntimeWarning)
-        kernel.shell_streams = [kernel.shell_stream, kernel.shell_stream]
-
-
 async def test_process_control(kernel):
     from jupyter_client.session import DELIM
 
@@ -142,12 +129,6 @@ async def test_dispatch_shell(kernel):
     await kernel.process_shell_message(msg)
 
 
-@pytest.mark.skip("kernelbase.do_one_iteration doesn't exist anymore")
-async def test_do_one_iteration(kernel):
-    kernel.msg_queue = asyncio.Queue()
-    await kernel.do_one_iteration()
-
-
 async def test_publish_debug_event(kernel):
     kernel._publish_debug_event({})
 
@@ -160,7 +141,7 @@ async def test_send_interrupt_children(kernel):
     kernel._send_interrupt_children()
 
 
-# TODO: this causes deadlock
-# async def test_direct_usage_request(kernel):
-#     reply = await kernel.test_control_message("usage_request", {})
-#     assert reply['header']['msg_type'] == 'usage_reply'
+@pytest.mark.skip(reason="this causes deadlock")
+async def test_direct_usage_request(kernel):
+    reply = await kernel.test_control_message("usage_request", {})
+    assert reply["header"]["msg_type"] == "usage_reply"

tests/test_kernelapp.py

@@ -118,7 +118,9 @@ def test_merge_connection_file():
 
 
 # FIXME: @pytest.mark.skipif(trio is None, reason="requires trio")
-@pytest.mark.skip()
+@pytest.mark.skip(
+    "Cant run under pytest-trio as IPKernelApp is the one starting the loop"
+)
 def test_trio_loop():
     app = IPKernelApp(trio_loop=True)