Skip to content

Commit 137112e

Browse files
committed
Fix tests
1 parent 19d189d commit 137112e

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

ipykernel/control.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
class ControlThread(Thread):
1111

12-
def __init__(self, log=None, **kwargs):
12+
def __init__(self, **kwargs):
1313
Thread.__init__(self, **kwargs)
1414
self.io_loop = IOLoop(make_current=False)
1515
self.pydev_do_not_trace = True

ipykernel/kernelapp.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,8 @@ def init_control(self, context):
301301

302302
self.debug_shell_socket = context.socket(zmq.DEALER)
303303
self.debug_shell_socket.linger = 1000
304-
self.debug_shell_socket.connect(self.shell_socket.getsockopt(zmq.LAST_ENDPOINT))
304+
if self.shell_socket.getsockopt(zmq.LAST_ENDPOINT):
305+
self.debug_shell_socket.connect(self.shell_socket.getsockopt(zmq.LAST_ENDPOINT))
305306

306307
if hasattr(zmq, 'ROUTER_HANDOVER'):
307308
# set router-handover to workaround zeromq reconnect problems
@@ -345,7 +346,10 @@ def close(self):
345346
self.iopub_thread.stop()
346347
self.iopub_thread.close()
347348

348-
self.debug_shell_socket.close()
349+
if self.debugpy_socket and not self.debugpy_socket.closed:
350+
self.debugpy_socket.close()
351+
if self.debug_shell_socket and not self.debug_shell_socket.closed:
352+
self.debug_shell_socket.close()
349353

350354
for channel in ('shell', 'control', 'stdin'):
351355
self.log.debug("Closing %s channel", channel)

ipykernel/kernelbase.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ def __init__(self, **kwargs):
187187
self.session)
188188

189189
self.control_queue = Queue()
190-
kwargs['control_thread'].io_loop.add_callback(self.poll_control_queue)
191-
190+
if 'control_thread' in kwargs:
191+
kwargs['control_thread'].io_loop.add_callback(self.poll_control_queue)
192192

193193
@gen.coroutine
194194
def dispatch_debugpy(self, msg):

0 commit comments

Comments
 (0)