dont capture with pytest

Author: Carreau

ipykernel/inprocess/tests/test_kernel.py

@@ -99,9 +99,8 @@ def test_stdout(self):
         out, err = assemble_output(kc.iopub_channel)
         assert out == 'bar\n'
 
-    @pytest.mark.skipif(
-        sys.platform == 'win32',
-        reason="not ment to work on windows"
+    @pytest.mark.skip(
+        reason="Currently don't capture during test as pytest does its own capturing"
     )
     def test_capfd(self):
         """ Does correctly capture fd

ipykernel/iostream.py

@@ -14,6 +14,7 @@
 from weakref import WeakSet
 import traceback
 from io import StringIO, TextIOBase
+import os
 
 import zmq
 if zmq.pyzmq_version_info() >= (17, 0):
@@ -364,9 +365,13 @@ def __init__(
         self._new_buffer()
         self.echo = None
 
-        if watchfd and (
-            sys.platform.startswith("linux") or sys.platform.startswith("darwin")
+        if (
+            watchfd
+            and (sys.platform.startswith("linux") or sys.platform.startswith("darwin"))
+            and ("PYTEST_CURRENT_TEST" not in os.environ)
         ):
+            # Pytest set its own capture. Dont redirect from within pytest.
+
             self._should_watch = True
             self._setup_stream_redirects(name)
 

ipykernel/tests/test_kernel.py

@@ -51,7 +51,10 @@ def test_simple_print():
         assert stderr == ''
         _check_master(kc, expected=True)
 
-@pytest.mark.skipif(sys.platform=='win32', reason='Not meant to work on windows')
+
+@pytest.mark.skip(
+    reason="Currently don't capture during test as pytest does its own capturing"
+)
 def test_capture_fd():
     """simple print statement in kernel"""
     with kernel() as kc: