Skip to content

Commit 154d49a

Browse files
committed
Use a better test name; remove unnecessary mock side_effect.
1 parent d4d870c commit 154d49a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

ipykernel/tests/test_heartbeat.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@ def test_port_bind_failure_raises():
2121
assert mock_try_bind.call_count == 1
2222

2323

24-
def test_port_bind_failure_succeeds():
24+
def test_port_bind_success():
2525
heart = Heartbeat(None)
2626
with patch.object(heart, '_try_bind_socket') as mock_try_bind:
27-
mock_try_bind.side_effect = lambda: None
2827
heart._bind_socket()
2928
assert mock_try_bind.call_count == 1
3029

0 commit comments

Comments
 (0)