Skip to content

Commit 29594ff

Browse files
authored
Merge pull request #596 from afshin/release-cleanup
Clean up release process and add tests
2 parents 4df8c2f + ba43397 commit 29594ff

File tree

5 files changed

+15
-4
lines changed

5 files changed

+15
-4
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,11 @@ jobs:
6060
timeout-minutes: 30
6161
run: |
6262
pytest ipykernel -vv -s --cov ipykernel --cov-branch --cov-report term-missing:skip-covered --durations 10
63+
- name: Build and check the dist files
64+
run: |
65+
pip install build twine
66+
python -m build .
67+
twine check dist/*
6368
- name: Coverage
6469
run: |
6570
codecov

RELEASE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ git tag $version; true;
1111
git push --all
1212
git push --tags
1313
rm -rf dist build
14-
python setup.py sdist
15-
python setup.py bdist_wheel
14+
pip install build twine
15+
python -m build .
1616
pip install twine
1717
twine check dist/*
1818
twine upload dist/*

ipykernel/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version_info = (5, 5, 0)
1+
version_info = (5, 6, 0, 'dev0')
22
__version__ = '.'.join(map(str, version_info[:3]))
33

44
# pep440 is annoying, beta/alpha/rc should _not_ have dots or pip/setuptools

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
[build-system]
2+
build-backend = "setuptools.build_meta"
23
requires=[
34
"setuptools",
45
"wheel",

setup.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ def run(self):
6565
raise ValueError("Version number '%s' is not valid (should match [N!]N(.N)*[{a|b|rc}N][.postN][.devN])" % current_version)
6666

6767

68+
with open(pjoin(here, 'README.md')) as fid:
69+
LONG_DESCRIPTION = fid.read()
70+
6871
setup_args = dict(
6972
name=name,
7073
version=current_version,
@@ -76,11 +79,12 @@ def run(self):
7679
py_modules=['ipykernel_launcher'],
7780
package_data=package_data,
7881
description="IPython Kernel for Jupyter",
82+
long_description_content_type="text/markdown",
7983
author='IPython Development Team',
8084
author_email='[email protected]',
8185
url='https://ipython.org',
8286
license='BSD',
83-
long_description="The IPython kernel for Jupyter",
87+
long_description=LONG_DESCRIPTION,
8488
platforms="Linux, Mac OS X, Windows",
8589
keywords=['Interactive', 'Interpreter', 'Shell', 'Web'],
8690
python_requires='>=3.5',
@@ -112,6 +116,7 @@ def run(self):
112116

113117

114118
if any(a.startswith(('bdist', 'install')) for a in sys.argv):
119+
sys.path.insert(0, here)
115120
from ipykernel.kernelspec import write_kernel_spec, make_ipkernel_cmd, KERNEL_NAME
116121

117122
# When building a wheel, the executable specified in the kernelspec is simply 'python'.

0 commit comments

Comments
 (0)