Skip to content

Commit 367d3d0

Browse files
authored
Don't rerun test with --lf it hides failures. (#1324)
1 parent a1f07b7 commit 367d3d0

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,19 +49,19 @@ jobs:
4949
timeout-minutes: 15
5050
if: ${{ !startsWith( matrix.python-version, 'pypy' ) && !startsWith(matrix.os, 'windows') }}
5151
run: |
52-
hatch run cov:test --cov-fail-under 50 || hatch run test:test --lf
52+
hatch run cov:test --cov-fail-under 50
5353
5454
- name: Run the tests on pypy
5555
timeout-minutes: 15
5656
if: ${{ startsWith( matrix.python-version, 'pypy' ) }}
5757
run: |
58-
hatch run test:nowarn || hatch run test:nowarn --lf
58+
hatch run test:nowarn
5959
6060
- name: Run the tests on Windows
6161
timeout-minutes: 15
6262
if: ${{ startsWith(matrix.os, 'windows') }}
6363
run: |
64-
hatch run cov:nowarn || hatch run test:nowarn --lf
64+
hatch run cov:nowarn
6565
6666
- name: Check Launcher
6767
run: |
@@ -144,7 +144,7 @@ jobs:
144144
145145
- name: Run the tests
146146
timeout-minutes: 15
147-
run: pytest -W default -vv || pytest --vv -W default --lf
147+
run: pytest -W default -vv
148148

149149
test_miniumum_versions:
150150
name: Test Minimum Versions
@@ -164,7 +164,7 @@ jobs:
164164
165165
- name: Run the unit tests
166166
run: |
167-
hatch -v run test:nowarn || hatch run test:nowarn --lf
167+
hatch -v run test:nowarn
168168
169169
test_prereleases:
170170
name: Test Prereleases
@@ -179,7 +179,7 @@ jobs:
179179
dependency_type: pre
180180
- name: Run the tests
181181
run: |
182-
hatch run test:nowarn || hatch run test:nowarn --lf
182+
hatch run test:nowarn
183183
184184
make_sdist:
185185
name: Make SDist

.readthedocs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 2
33
build:
44
os: ubuntu-22.04
55
tools:
6-
python: "3.11"
6+
python: "3.13"
77

88
sphinx:
99
configuration: docs/conf.py

tests/test_eventloop.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,16 @@ def test_cocoa_loop(kernel):
9898
loop_cocoa(kernel)
9999

100100

101-
@pytest.mark.skipif(
102-
len(qt_guis_avail) == 0, reason="No viable version of PyQt or PySide installed."
103-
)
104-
def test_qt_enable_gui(kernel, capsys):
105-
gui = qt_guis_avail[0]
106-
101+
@pytest.mark.parametrize("gui", qt_guis_avail)
102+
def test_qt_enable_gui(gui, kernel, capsys):
103+
if os.getenv("GITHUB_ACTIONS", None) == "true" and gui == "qt5":
104+
pytest.skip("Qt5 and GitHub action crash CPython")
105+
if gui == "qt6" and sys.version_info < (3, 10):
106+
pytest.skip(
107+
"qt6 fails on 3.9 with AttributeError: module 'PySide6.QtPrintSupport' has no attribute 'QApplication'"
108+
)
109+
if sys.platform == "linux" and gui == "qt6" and os.getenv("GITHUB_ACTIONS", None) == "true":
110+
pytest.skip("qt6 fails on github CI with missing libEGL.so.1")
107111
enable_gui(gui, kernel)
108112

109113
# We store the `QApplication` instance in the kernel.

0 commit comments

Comments
 (0)