Backports from anyio (old main) branch to main branch (#1402)

Co-authored-by: Gregory Shklover <[email protected]>
Co-authored-by: bluss <[email protected]>
Co-authored-by: M Bussonnier <[email protected]>
Co-authored-by: Min RK <[email protected]>
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: Stephen Macke <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 8 people

.github/workflows/downstream.yml

@@ -38,7 +38,7 @@ jobs:
         uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
         with:
           package_name: ipywidgets
-          test_command: pytest -vv -raXxs -k \"not deprecation_fa_icons and not tooltip_deprecation and not on_submit_deprecation\" -W default --durations 10 --color=yes
+          test_command: pytest -vv -raXxs -W default --durations 10 --color=yes
 
   jupyter_client:
     runs-on: ubuntu-latest
@@ -56,6 +56,7 @@ jobs:
 
   ipyparallel:
     runs-on: ubuntu-latest
+    timeout-minutes: 20
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -147,20 +148,3 @@ jobs:
         run: |
           cd ${GITHUB_WORKSPACE}/../spyder-kernels
           xvfb-run --auto-servernum ${pythonLocation}/bin/python -m pytest -x -vv -s --full-trace --color=yes spyder_kernels
-
-  downstream_check: # This job does nothing and is only used for the branch protection
-    if: always()
-    needs:
-      - nbclient
-      - ipywidgets
-      - jupyter_client
-      - ipyparallel
-      - jupyter_kernel_test
-      - spyder_kernels
-      - qtconsole
-    runs-on: ubuntu-latest
-    steps:
-      - name: Decide whether the needed jobs succeeded or failed
-        uses: re-actors/alls-green@release/v1
-        with:
-          jobs: ${{ toJSON(needs) }}

.github/workflows/nightly.yml

@@ -0,0 +1,33 @@
+name: nightly build and upload
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 0 * * *"
+
+defaults:
+  run:
+    shell: bash -eux {0}
+
+jobs:
+  build:
+    runs-on: "ubuntu-latest"
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ["3.12"]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Base Setup
+        uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
+
+      - name: Build
+        run: |
+          python -m pip install build
+          python -m build
+      - name: Upload wheel
+        uses: scientific-python/upload-nightly-action@82396a2ed4269ba06c6b2988bb4fd568ef3c3d6b # 0.6.1
+        with:
+          artifacts_path: dist
+          anaconda_nightly_upload_token: ${{secrets.UPLOAD_TOKEN}}

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 ci:
-  autoupdate_schedule: monthly
   autoupdate_commit_msg: "chore: update pre-commit hooks"
+  autoupdate_schedule: weekly
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
@@ -40,7 +40,7 @@ repos:
         types_or: [yaml, html, json]
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: "v1.8.0"
+    rev: "v1.16.1"
     hooks:
       - id: mypy
         files: ipykernel
@@ -74,7 +74,7 @@ repos:
       - id: rst-inline-touching-normal
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.2.0
+    rev: v0.11.4
     hooks:
       - id: ruff
         types_or: [python, jupyter]

examples/embedding/inprocess_qtconsole.py

@@ -1,54 +1,25 @@
 """An in-process qt console app."""
+
 import os
-import sys
 
 import tornado
 from IPython.lib import guisupport
 from qtconsole.inprocess import QtInProcessKernelManager
 from qtconsole.rich_ipython_widget import RichIPythonWidget
 
+assert tornado.version_info >= (6, 1)
+
 
 def print_process_id():
     """Print the process id."""
     print("Process ID is:", os.getpid())
 
 
-def init_asyncio_patch():
-    """set default asyncio policy to be compatible with tornado
-    Tornado 6 (at least) is not compatible with the default
-    asyncio implementation on Windows
-    Pick the older SelectorEventLoopPolicy on Windows
-    if the known-incompatible default policy is in use.
-    do this as early as possible to make it a low priority and overridable
-    ref: https://github.com/tornadoweb/tornado/issues/2608
-    FIXME: if/when tornado supports the defaults in asyncio,
-           remove and bump tornado requirement for py38
-    """
-    if (
-        sys.platform.startswith("win")
-        and sys.version_info >= (3, 8)
-        and tornado.version_info < (6, 1)
-    ):
-        import asyncio
-
-        try:
-            from asyncio import WindowsProactorEventLoopPolicy, WindowsSelectorEventLoopPolicy
-        except ImportError:
-            pass
-            # not affected
-        else:
-            if type(asyncio.get_event_loop_policy()) is WindowsProactorEventLoopPolicy:
-                # WindowsProactorEventLoopPolicy is not compatible with tornado 6
-                # fallback to the pre-3.8 default of Selector
-                asyncio.set_event_loop_policy(WindowsSelectorEventLoopPolicy())
-
-
 def main():
     """The main entry point."""
     # Print the ID of the main process
     print_process_id()
 
-    init_asyncio_patch()
     app = guisupport.get_app_qt4()
 
     # Create an in-process kernel

examples/embedding/inprocess_terminal.py

@@ -1,4 +1,5 @@
 """An in-process terminal example."""
+
 import os
 import sys
 

examples/embedding/ipkernel_wxapp.py

@@ -16,6 +16,7 @@
 
 Ref: Modified from wxPython source code wxPython/samples/simple/simple.py
 """
+
 # -----------------------------------------------------------------------------
 # Imports
 # -----------------------------------------------------------------------------

hatch_build.py

@@ -1,4 +1,5 @@
 """A custom hatch build hook for ipykernel."""
+
 import shutil
 import sys
 from pathlib import Path

ipykernel/__main__.py

@@ -1,4 +1,5 @@
 """The cli entry point for ipykernel."""
+
 if __name__ == "__main__":
     from ipykernel import kernelapp as app
 

ipykernel/_version.py

@@ -1,6 +1,7 @@
 """
 store the current version info of the server.
 """
+
 import re
 
 # Version string must appear intact for hatch versioning

ipykernel/comm/comm.py

@@ -49,7 +49,7 @@ def publish_msg(self, msg_type, data=None, metadata=None, buffers=None, **keys):
 class Comm(BaseComm, traitlets.config.LoggingConfigurable):
     """Class for communicating between a Frontend and a Kernel"""
 
-    kernel = Instance("ipykernel.kernelbase.Kernel", allow_none=True)  # type:ignore[assignment]
+    kernel = Instance("ipykernel.kernelbase.Kernel", allow_none=True)
     comm_id = Unicode()
     primary = Bool(True, help="Am I the primary or secondary Comm?")