Skip to content

Commit 5e5608d

Browse files
committed
Merge pull request #59 from michaelpacer/fix_typo
Fixes typo in InstallIPythonKernelSpecApp
2 parents 4cda22a + 64d2a11 commit 5e5608d

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

ipykernel/kernelspec.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def start(self):
153153
opts = parser.parse_args(self.argv)
154154
try:
155155
dest = install(user=opts.user, kernel_name=opts.name, prefix=opts.prefix,
156-
dispay_name=opts.display_name,
156+
display_name=opts.display_name,
157157
)
158158
except OSError as e:
159159
if e.errno == errno.EACCES:

ipykernel/tests/test_kernelspec.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import shutil
88
import sys
99
import tempfile
10-
10+
1111
try:
1212
from unittest import mock
1313
except ImportError:
@@ -20,6 +20,7 @@
2020
get_kernel_dict,
2121
write_kernel_spec,
2222
install,
23+
InstallIPythonKernelSpecApp,
2324
KERNEL_NAME,
2425
RESOURCES,
2526
)
@@ -75,6 +76,17 @@ def test_write_kernel_spec_path():
7576
shutil.rmtree(path)
7677

7778

79+
def test_install_kernelspec():
80+
81+
path = tempfile.mkdtemp()
82+
try:
83+
test = InstallIPythonKernelSpecApp.launch_instance(argv=['--prefix', path])
84+
assert_is_spec(os.path.join(
85+
path, 'share', 'jupyter', 'kernels', KERNEL_NAME))
86+
finally:
87+
shutil.rmtree(path)
88+
89+
7890
def test_install_user():
7991
tmp = tempfile.mkdtemp()
8092

0 commit comments

Comments
 (0)