Unmark flaky tests

Author: davidbrochart

tests/test_debugger.py

@@ -1,7 +1,6 @@
 import sys
 
 import pytest
-from flaky import flaky
 
 from .utils import TIMEOUT, get_reply, new_kernel
 
@@ -74,7 +73,6 @@ def kernel_with_debug(kernel):
         wait_for_debug_request(kernel, "disconnect", {"restart": False, "terminateDebuggee": True})
 
 
-@flaky(max_runs=3)
 def test_debug_initialize(kernel):
     reply = wait_for_debug_request(
         kernel,
@@ -168,7 +166,6 @@ def func(b):
         assert r == {}
 
 
-@flaky(max_runs=3)
 def test_stop_on_breakpoint(kernel_with_debug):
     code = """def f(a, b):
     c = a + b
@@ -211,7 +208,6 @@ def test_stop_on_breakpoint(kernel_with_debug):
     assert msg["content"]["body"]["reason"] == "breakpoint"
 
 
-@flaky(max_runs=3)
 def test_breakpoint_in_cell_with_leading_empty_lines(kernel_with_debug):
     code = """
 def f(a, b):
@@ -255,7 +251,6 @@ def f(a, b):
     assert msg["content"]["body"]["reason"] == "breakpoint"
 
 
-@flaky(max_runs=3)
 def test_rich_inspect_not_at_breakpoint(kernel_with_debug):
     var_name = "text"
     value = "Hello the world"
@@ -288,7 +283,6 @@ def func(v):
         assert reply == {}
 
 
-@flaky(max_runs=3)
 def test_rich_inspect_at_breakpoint(kernel_with_debug):
     code = """def f(a, b):
     c = a + b

tests/test_eventloop.py

@@ -7,7 +7,6 @@
 import time
 
 import pytest
-from flaky import flaky
 
 from ipykernel.eventloops import (
     enable_gui,
@@ -58,7 +57,6 @@ def _setup_env():
 windows_skip = pytest.mark.skipif(os.name == "nt", reason="causing failures on windows")
 
 
-@flaky(max_runs=3)
 @windows_skip
 @pytest.mark.skipif(sys.platform == "darwin", reason="hangs on macos")
 def test_tk_loop(kernel):
@@ -80,7 +78,6 @@ def do_thing():
     t.join()
 
 
-@flaky(max_runs=3)
 @windows_skip
 @pytest.mark.parametrize("anyio_backend", ["asyncio"])
 def test_asyncio_loop(kernel):
@@ -97,13 +94,11 @@ def test_enable_gui(kernel):
     enable_gui("tk", kernel)
 
 
-@flaky(max_runs=3)
 @pytest.mark.skipif(sys.platform != "darwin", reason="MacOS-only")
 def test_cocoa_loop(kernel):
     loop_cocoa(kernel)
 
 
-@flaky(max_runs=3)
 @pytest.mark.parametrize("gui", qt_guis_avail)
 def test_qt_enable_gui(gui, kernel, capsys):
     if os.getenv("GITHUB_ACTIONS", None) == "true" and gui == "qt5":

tests/test_io.py

@@ -14,7 +14,6 @@
 import zmq
 import zmq_anyio
 from anyio import create_task_group
-from flaky import flaky
 from jupyter_client.session import Session
 
 from ipykernel.iostream import _PARENT, BackgroundSocket, IOPubThread, OutStream
@@ -102,7 +101,6 @@ async def test_background_socket(iopub_thread):
     sock.send(b"hi")
 
 
-@flaky(max_runs=3)
 async def test_outstream(iopub_thread):
     session = Session()
     pub = iopub_thread.socket

tests/test_kernel.py

@@ -49,7 +49,6 @@ def _check_status(content):
 # printing tests
 
 
-@flaky(max_runs=3)
 def test_simple_print():
     """simple print statement in kernel"""
     with kernel() as kc:
@@ -200,7 +199,6 @@ def test_sys_path():
     assert "" in sys_path
 
 
-@flaky(max_runs=3)
 def test_sys_path_profile_dir():
     """test that sys.path doesn't get messed up when `--profile-dir` is specified"""
 
@@ -558,7 +556,6 @@ def test_interrupt_during_pdb_set_trace():
         validate_message(reply, "execute_reply", msg_id2)
 
 
-@flaky(max_runs=3)
 def test_control_thread_priority():
     N = 5
     with new_kernel() as kc:
@@ -603,7 +600,6 @@ def test_control_thread_priority():
     assert control_dates[-1] <= shell_dates[0]
 
 
-@flaky(max_runs=3)
 def test_sequential_control_messages():
     with new_kernel() as kc:
         msg_id = kc.execute("import time")

tests/test_subshells.py

@@ -9,7 +9,6 @@
 from datetime import datetime, timedelta
 
 import pytest
-from flaky import flaky
 from jupyter_client.blocking.client import BlockingKernelClient
 
 from .utils import TIMEOUT, get_replies, get_reply, new_kernel
@@ -76,7 +75,6 @@ def execute_thread_ids(kc: BlockingKernelClient, subshell_id: str | None = None)
 # Tests
 
 
-@flaky(max_runs=3)
 def test_supported():
     with new_kernel() as kc:
         msg_id = kc.kernel_info()
@@ -85,7 +83,6 @@ def test_supported():
         assert "kernel subshells" in reply["content"]["supported_features"]
 
 
-@flaky(max_runs=3)
 def test_subshell_id_lifetime():
     with new_kernel() as kc:
         assert list_subshell_helper(kc)["subshell_id"] == []
@@ -102,7 +99,6 @@ def test_delete_non_existent():
         assert "evalue" in reply
 
 
-@flaky(max_runs=3)
 def test_thread_counts():
     with new_kernel() as kc:
         nthreads = execute_thread_count(kc)
@@ -176,7 +172,6 @@ def test_run_concurrently_sequence(are_subshells, overlap):
             assert reply["content"]["status"] == "ok", reply
 
 
-@flaky(max_runs=3)
 @pytest.mark.parametrize("include_main_shell", [True, False])
 def test_run_concurrently_timing(include_main_shell):
     with new_kernel() as kc:
@@ -256,7 +251,6 @@ def test_execution_count():
         assert execution_counts == [ec, ec - 1, ec + 2, ec + 1]
 
 
-@flaky(max_runs=3)
 def test_create_while_execute():
     with new_kernel() as kc:
         # Send request to execute code on main subshell.
@@ -278,7 +272,6 @@ def test_create_while_execute():
         assert control_date < shell_date
 
 
-@flaky(max_runs=3)
 @pytest.mark.skipif(
     platform.python_implementation() == "PyPy",
     reason="does not work on PyPy",