Skip to content

Commit 67e1c32

Browse files
committed
try running tests with xvfb on linux
1 parent db61391 commit 67e1c32

File tree

3 files changed

+8
-15
lines changed

3 files changed

+8
-15
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,11 @@ jobs:
5353
with:
5454
python-version: ${{ matrix.python-version }}
5555

56+
- name: setup xvfb
57+
if: ${{ startsWith(matrix.runs-on, 'ubuntu) }}
58+
run: |
59+
echo "PRE_TEST=xvfb-run --auto-servernum" >> "$GITHUB_ENV"
60+
5661
- name: set qt env
5762
run: |
5863
echo "QT=${{ matrix.qt }}" >> $GITHUB_ENV
@@ -67,19 +72,19 @@ jobs:
6772
timeout-minutes: 15
6873
if: ${{ !startsWith( matrix.python-version, 'pypy' ) && !startsWith(matrix.os, 'windows') }}
6974
run: |
70-
hatch run cov:test --cov-fail-under 50
75+
${PRE_TEST-} hatch run cov:test --cov-fail-under 50
7176
7277
- name: Run the tests on pypy
7378
timeout-minutes: 15
7479
if: ${{ startsWith( matrix.python-version, 'pypy' ) }}
7580
run: |
76-
hatch run test:nowarn --ignore=tests/test_debugger.py
81+
${PRE_TEST-} hatch run test:nowarn --ignore=tests/test_debugger.py
7782
7883
- name: Run the tests on Windows
7984
timeout-minutes: 15
8085
if: ${{ !startsWith( matrix.python-version, 'pypy' ) && startsWith(matrix.os, 'windows') }}
8186
run: |
82-
hatch run cov:nowarn
87+
${PRE_TEST-} hatch run cov:nowarn
8388
8489
- name: Check Launcher
8590
run: |

tests/test_eventloop.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,6 @@ def test_cocoa_loop(kernel):
100100

101101
@pytest.mark.parametrize("gui", qt_guis_avail)
102102
def test_qt_enable_gui(gui, kernel, capsys):
103-
if os.getenv("GITHUB_ACTIONS", None) == "true" and gui == "qt5":
104-
pytest.skip("Qt5 and GitHub action crash CPython")
105-
if gui == "qt6" and sys.version_info < (3, 10):
106-
pytest.skip(
107-
"qt6 fails on 3.9 with AttributeError: module 'PySide6.QtPrintSupport' has no attribute 'QApplication'"
108-
)
109-
if sys.platform == "linux" and gui == "qt6" and os.getenv("GITHUB_ACTIONS", None) == "true":
110-
pytest.skip("qt6 fails on github CI with missing libEGL.so.1")
111103
enable_gui(gui, kernel)
112104

113105
# We store the `QApplication` instance in the kernel.

tests/test_matplotlib_eventloops.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import os
21
import sys
32
import time
43

@@ -38,9 +37,6 @@ def execute(
3837
def test_matplotlib_gui(kc, gui):
3938
"""Make sure matplotlib activates and its eventloop runs while the kernel is also responsive"""
4039
pytest.importorskip("matplotlib", reason="this test requires matplotlib")
41-
if gui in {"tk", "qt"} and os.getenv("GITHUB_ACTIONS") and sys.platform == "linux":
42-
pytest.skip("tk, qt tests not working yet on Linux CI")
43-
4440
stdout, stderr = execute(kc, f"%matplotlib {gui}")
4541
assert not stderr
4642
# debug: show output from invoking the matplotlib magic

0 commit comments

Comments
 (0)