Commit 6ce76ca
committed
Stop using deprecated recv_multipart when using in-process socket.
Found while working on napari/napari#3314
I'm not too sure this is the right fix, as BackgroundSocket is used only
in inprocess kernel, and that in general io_pub socket looks like the
can be `Any()` and that therefore may not have a io_thread.
But if that's the case, then should we maybe un-deprecate recv_multipart on background socket ?
the recv in jupyter_client side (which is called by the line I change
here) is
def recv(self, socket, mode=zmq.NOBLOCK, content=True, copy=True):
"""Receive and unpack a message.
Parameters
----------
socket : ZMQStream or Socket
The socket or stream to use in receiving.
Returns
-------
[idents], msg
[idents] is a list of idents and msg is a nested message dict of
same format as self.msg returns.
"""
if isinstance(socket, ZMQStream):
socket = socket.socket
try:
msg_list = socket.recv_multipart(mode, copy=copy) # this will trigger deprecation warning
except zmq.ZMQError as e:
...
And I doubt we want to make that aware of background socket.1 parent cf2d56e commit 6ce76ca
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| |||
0 commit comments