update mypy errors

Author: Carreau

.pre-commit-config.yaml

@@ -44,7 +44,6 @@ repos:
     hooks:
       - id: mypy
         files: ipykernel
-        stages: [manual]
         args: ["--install-types", "--non-interactive"]
         additional_dependencies:
           [

ipykernel/inprocess/blocking.py

@@ -69,6 +69,7 @@ def call_handlers(self, msg):
             _raw_input = self.client.kernel._sys_raw_input
             prompt = msg["content"]["prompt"]
             print(prompt, end="", file=sys.__stdout__)
+            assert sys.__stdout__ is not None
             sys.__stdout__.flush()
             self.client.input(_raw_input())
 

ipykernel/inprocess/client.py

@@ -11,6 +11,8 @@
 # Imports
 # -----------------------------------------------------------------------------
 
+from typing import Any
+
 from jupyter_client.client import KernelClient
 from jupyter_client.clientabc import KernelClientABC
 
@@ -54,9 +56,9 @@ def _default_blocking_class(self):
 
         return BlockingInProcessKernelClient
 
-    def get_connection_info(self):
+    def get_connection_info(self, session: bool = False):
         """Get the connection info for the client."""
-        d = super().get_connection_info()
+        d = super().get_connection_info(session=session)
         d["kernel"] = self.kernel  # type:ignore[assignment]
         return d
 
@@ -99,9 +101,18 @@ def hb_channel(self):
     # Methods for sending specific messages
     # -------------------------------------
 
-    async def execute(
-        self, code, silent=False, store_history=True, user_expressions=None, allow_stdin=None
-    ):
+    # Feb 2025: superclass in jupyter-Client is sync,
+    # it should likely be made all consistent and push
+    # jupyter_client async as well
+    async def execute(  # type:ignore [override]
+        self,
+        code: str,
+        silent: bool = False,
+        store_history: bool = True,
+        user_expressions: dict[str, Any] | None = None,
+        allow_stdin: bool | None = None,
+        stop_on_error: bool = True,
+    ) -> str:
         """Execute code on the client."""
         if allow_stdin is None:
             allow_stdin = self.allow_stdin
@@ -114,7 +125,9 @@ async def execute(
         )
         msg = self.session.msg("execute_request", content)
         await self._dispatch_to_kernel(msg)
-        return msg["header"]["msg_id"]
+        res = msg["header"]["msg_id"]
+        assert isinstance(res, str)
+        return res
 
     async def complete(self, code, cursor_pos=None):
         """Get code completion."""

ipykernel/inprocess/session.py

@@ -1,8 +1,17 @@
+from typing import Any
+
 from jupyter_client.session import Session as _Session
 
 
 class Session(_Session):
-    async def recv(self, socket, copy=True):
+    # superclass is not async.
+    async def recv(  # type: ignore[override]
+        self, socket, mode: int = 0, content: bool = True, copy=True
+    ) -> Any:
+        """
+        mode, content, copy have no effect, but are present for superclass compatibility
+
+        """
         return await socket.recv_multipart()
 
     def send(

ipykernel/zmqshell.py

@@ -78,12 +78,16 @@ def _hooks(self):
             self._thread_local.hooks = []
         return self._thread_local.hooks
 
-    def publish(
+    # Feb: 2025IPython has a deprecated, `source` parameter, marked for removal that
+    # triggers typing errors.
+    def publish(  # type: ignore [override]
         self,
         data,
         metadata=None,
+        *,
         transient=None,
         update=False,
+        **kwargs,
     ):
         """Publish a display-data message
 
@@ -508,7 +512,7 @@ def _update_exit_now(self, change):
 
     # Over ZeroMQ, GUI control isn't done with PyOS_InputHook as there is no
     # interactive input being read; we provide event loop support in ipkernel
-    def enable_gui(self, gui):
+    def enable_gui(self, gui=None):
         """Enable a given guil."""
         from .eventloops import enable_gui as real_enable_gui
 
@@ -654,14 +658,10 @@ def set_parent(self, parent):
         self.display_pub.set_parent(parent)  # type:ignore[attr-defined]
         if hasattr(self, "_data_pub"):
             self.data_pub.set_parent(parent)
-        try:
-            sys.stdout.set_parent(parent)  # type:ignore[attr-defined]
-        except AttributeError:
-            pass
-        try:
-            sys.stderr.set_parent(parent)  # type:ignore[attr-defined]
-        except AttributeError:
-            pass
+        if hasattr(sys.stdout, "set_parent"):
+            sys.stdout.set_parent(parent)
+        if hasattr(sys.stderr, "set_parent"):
+            sys.stderr.set_parent(parent)
 
     def get_parent(self):
         """Get the parent header."""