-

Author: davidbrochart

tests/test_io.py

@@ -37,11 +37,12 @@ async def iopub_thread(ctx):
             thread = IOPubThread(pub)
             thread.start()
 
-            yield thread
-
-            await pub.stop()
-            thread.stop()
-            thread.close()
+            try:
+                yield thread
+            finally:
+                await pub.stop()
+                thread.stop()
+                thread.close()
     except BaseException:
         pass
 

tests/test_kernel.py

@@ -62,7 +62,7 @@ def test_simple_print():
 def test_print_to_correct_cell_from_thread():
     """should print to the cell that spawned the thread, not a subsequently run cell"""
     iterations = 5
-    interval = 1
+    interval = 0.25
     code = f"""\
     from threading import Thread
     from time import sleep
@@ -94,7 +94,7 @@ def thread_target():
 def test_print_to_correct_cell_from_child_thread():
     """should print to the cell that spawned the thread, not a subsequently run cell"""
     iterations = 5
-    interval = 1
+    interval = 0.25
     code = f"""\
     from threading import Thread
     from time import sleep
@@ -132,7 +132,7 @@ def parent_target():
 def test_print_to_correct_cell_from_asyncio():
     """should print to the cell that scheduled the task, not a subsequently run cell"""
     iterations = 5
-    interval = 1
+    interval = 0.25
     code = f"""\
     import asyncio
 

tests/test_zmq_shell.py

@@ -229,10 +229,9 @@ def test_magics(tmp_path):
         if os.name == "posix":
             magics.man("ls")
         magics.autosave("10")
-
+    finally:
         socket.close()
         context.destroy()
-    finally:
         shell.configurables = []
         InteractiveShell.clear_instance()