Review

Author: davidbrochart

ipykernel/iostream.py

@@ -49,7 +49,7 @@ class IOPubThread:
     whose IO is always run in a thread.
     """
 
-    def __init__(self, socket: zmq_anyio.Socket, pipe=False):
+    def __init__(self, socket: zmq_anyio.Socket, pipe: bool = False):
         """Create IOPub thread
 
         Parameters

tests/test_async.py

@@ -31,7 +31,6 @@ def test_async_await():
 
 
 @pytest.mark.skipif(os.name == "nt", reason="Cannot interrupt on Windows")
-@pytest.mark.parametrize("anyio_backend", ["asyncio"])  # FIXME: %autoawait trio
 def test_async_interrupt(anyio_backend, request):
     assert KC is not None
     assert KM is not None

tests/test_embed_kernel.py

@@ -109,10 +109,7 @@ def test_embed_kernel_basic():
     with setup_kernel(cmd) as client:
         # oinfo a (int)
         client.inspect("a")
-        while True:
-            msg = client.get_shell_msg(timeout=TIMEOUT)
-            if msg["msg_type"] == "inspect_reply":
-                break
+        msg = client.get_shell_msg(timeout=TIMEOUT)
         content = msg["content"]
         assert content["found"]
 

tests/test_io.py

@@ -18,8 +18,6 @@
 
 from ipykernel.iostream import _PARENT, BackgroundSocket, IOPubThread, OutStream
 
-pytestmark = pytest.mark.anyio
-
 
 @pytest.fixture()
 def ctx():