Skip to content

Commit c725c1f

Browse files
Test more python versions on 6.x branch (#1398)
Co-authored-by: David Brochart <[email protected]>
1 parent 2320380 commit c725c1f

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,13 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
os: [ubuntu-latest, windows-latest, macos-latest]
25-
python-version: ["3.9", "3.13"]
26-
include:
27-
- os: ubuntu-latest
28-
python-version: "pypy-3.9"
29-
- os: macos-latest
30-
python-version: "3.10"
31-
- os: ubuntu-latest
32-
python-version: "3.11"
33-
- os: ubuntu-latest
34-
python-version: "3.12"
25+
python-version:
26+
- "3.9"
27+
- "3.10"
28+
- "3.11"
29+
- "3.12"
30+
- "3.13"
31+
- "pypy-3.10"
3532
steps:
3633
- name: Checkout
3734
uses: actions/checkout@v4
@@ -59,7 +56,7 @@ jobs:
5956
6057
- name: Run the tests on Windows
6158
timeout-minutes: 15
62-
if: ${{ startsWith(matrix.os, 'windows') }}
59+
if: ${{ !startsWith( matrix.python-version, 'pypy' ) && ${{ startsWith(matrix.os, 'windows') }}
6360
run: |
6461
hatch run cov:nowarn
6562

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Pre-release to allow further testing of subshell implementation.
1414

1515
### Bugs fixed
1616

17-
- [Bugfix] Set shell idle when message skipped by "should_handle" in "dispatch_shell" [#1395](https://github.com/ipython/ipykernel/pull/1395) ([@dby-tmwctw](https://github.com/dby-tmwctw))
17+
- \[Bugfix\] Set shell idle when message skipped by "should_handle" in "dispatch_shell" [#1395](https://github.com/ipython/ipykernel/pull/1395) ([@dby-tmwctw](https://github.com/dby-tmwctw))
1818

1919
### Maintenance and upkeep improvements
2020

ipykernel/socket_pair.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def pause_on_recv(self):
4747
self.to_stream.stop_on_recv()
4848

4949
def resume_on_recv(self):
50-
if self.to_stream is not None:
50+
if self.to_stream is not None and not self.to_stream.closed():
5151
self.to_stream.on_recv(self.on_recv_callback, copy=self.on_recv_copy)
5252

5353
def _address(self, name) -> str:

0 commit comments

Comments
 (0)