Skip to content

Commit c9a3bb6

Browse files
authored
Added kernel_protocol_version to kernelspec (#1483)
Although not required for kernel protocol < 5.5, this will simplify the upgrade. This needs jupyter/jupyter_client#1097 to be merged first.
2 parents 29c2422 + ad85e42 commit c9a3bb6

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

ipykernel/kernelspec.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def get_kernel_dict(
6767
"display_name": "Python %i (ipykernel)" % sys.version_info[0],
6868
"language": "python",
6969
"metadata": {"debugger": True},
70+
"kernel_protocol_version": "5.4",
7071
}
7172

7273

tests/test_kernelspec.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def assert_kernel_dict(d):
3535
assert d["argv"] == make_ipkernel_cmd()
3636
assert d["display_name"] == "Python %i (ipykernel)" % sys.version_info[0]
3737
assert d["language"] == "python"
38+
assert d["kernel_protocol_version"] == "5.4"
3839

3940

4041
def test_get_kernel_dict():
@@ -46,6 +47,7 @@ def assert_kernel_dict_with_profile(d):
4647
assert d["argv"] == make_ipkernel_cmd(extra_arguments=["--profile", "test"])
4748
assert d["display_name"] == "Python %i (ipykernel)" % sys.version_info[0]
4849
assert d["language"] == "python"
50+
assert d["kernel_protocol_version"] == "5.4"
4951

5052

5153
def test_get_kernel_dict_with_profile():

0 commit comments

Comments
 (0)