Skip to content

Commit ca794bf

Browse files
committed
Remove impossible skipif.
According to the dependencies in setup.py those will never be skipped.
1 parent 4715b9b commit ca794bf

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

ipykernel/tests/test_async.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,14 @@ def teardown_function():
2626
KM.shutdown_kernel(now=True)
2727

2828

29-
skip_without_async = pytest.mark.skipif(
30-
sys.version_info < (3, 5) or V(IPython.__version__) < V("7.0"),
31-
reason="IPython >=7 with async/await required",
32-
)
3329

34-
35-
@skip_without_async
3630
def test_async_await():
3731
flush_channels(KC)
3832
msg_id, content = execute("import asyncio; await asyncio.sleep(0.1)", KC)
3933
assert content["status"] == "ok", content
4034

4135

4236
@pytest.mark.parametrize("asynclib", ["asyncio", "trio", "curio"])
43-
@skip_without_async
4437
def test_async_interrupt(asynclib, request):
4538
try:
4639
__import__(asynclib)

ipykernel/tests/test_eventloop.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ def teardown():
2828
"""
2929

3030

31-
@pytest.mark.skipif(sys.version_info < (3, 5), reason="async/await syntax required")
3231
@pytest.mark.skipif(tornado.version_info < (5,), reason="only relevant on tornado 5")
3332
def test_asyncio_interrupt():
3433
flush_channels(KC)

ipykernel/tests/test_kernel.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -415,10 +415,6 @@ def test_interrupt_with_message():
415415
validate_message(reply, 'execute_reply', msg_id)
416416

417417

418-
@pytest.mark.skipif(
419-
version.parse(IPython.__version__) < version.parse("7.14.0"),
420-
reason="Need new IPython"
421-
)
422418
def test_interrupt_during_pdb_set_trace():
423419
"""
424420
The kernel exits after being interrupted while waiting in pdb.set_trace().

0 commit comments

Comments
 (0)