Skip to content

Commit e2463ec

Browse files
authored
Merge pull request #748 from Carreau/skipif
Remove Nose skipIf in favor of pytest
2 parents 3be20d4 + fff924d commit e2463ec

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

ipykernel/tests/test_message_spec.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
from queue import Empty
1010

1111
import nose.tools as nt
12-
from nose.plugins.skip import SkipTest
12+
13+
import pytest
14+
15+
import jupyter_client
1316

1417
from traitlets import (
1518
HasTraits, TraitError, Bool, Unicode, Dict, Integer, List, Enum
@@ -483,10 +486,12 @@ def test_connect_request():
483486
validate_message(reply, 'connect_reply', msg_id)
484487

485488

489+
@pytest.mark.skipif(
490+
jupyter_client.version_info < (5, 0),
491+
reason="earlier Jupyter Client don't have comm_info",
492+
)
486493
def test_comm_info_request():
487494
flush_channels()
488-
if not hasattr(KC, 'comm_info'):
489-
raise SkipTest()
490495
msg_id = KC.comm_info()
491496
reply = get_reply(KC, msg_id, TIMEOUT)
492497
validate_message(reply, 'comm_info_reply', msg_id)

0 commit comments

Comments
 (0)