Skip to content

Commit f330f6c

Browse files
committed
Delete always skipped tests that used removed attributes.
There are few chances we will ever use them again.
1 parent e64fb2e commit f330f6c

File tree

2 files changed

+4
-60
lines changed

2 files changed

+4
-60
lines changed

tests/test_ipkernel_direct.py

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -152,49 +152,12 @@ async def test_direct_clear(ipkernel):
152152
ipkernel.do_clear()
153153

154154

155-
@pytest.mark.skip("ipykernel._cancel_on_sigint doesn't exist anymore")
156-
async def test_cancel_on_sigint(ipkernel: IPythonKernel) -> None:
157-
future: asyncio.Future = asyncio.Future()
158-
# with ipkernel._cancel_on_sigint(future):
159-
# pass
160-
future.set_result(None)
161-
162-
163155
async def test_dispatch_debugpy(ipkernel: IPythonKernel) -> None:
164156
msg = ipkernel.session.msg("debug_request", {})
165157
msg_list = ipkernel.session.serialize(msg)
166158
await ipkernel.receive_debugpy_message(msg_list)
167159

168160

169-
@pytest.mark.skip("Queues don't exist anymore")
170-
async def test_start(ipkernel: IPythonKernel) -> None:
171-
shell_future: asyncio.Future = asyncio.Future()
172-
173-
async def fake_dispatch_queue():
174-
shell_future.set_result(None)
175-
176-
ipkernel.dispatch_queue = fake_dispatch_queue # type:ignore
177-
ipkernel.start()
178-
ipkernel.debugpy_stream = None
179-
ipkernel.start()
180-
await ipkernel.process_one(False)
181-
await shell_future
182-
183-
184-
@pytest.mark.skip("Queues don't exist anymore")
185-
async def test_start_no_debugpy(ipkernel: IPythonKernel) -> None:
186-
shell_future: asyncio.Future = asyncio.Future()
187-
188-
async def fake_dispatch_queue():
189-
shell_future.set_result(None)
190-
191-
ipkernel.dispatch_queue = fake_dispatch_queue # type:ignore
192-
ipkernel.debugpy_stream = None
193-
ipkernel.start()
194-
195-
await shell_future
196-
197-
198161
def test_create_comm():
199162
assert isinstance(_create_comm(), BaseComm)
200163

tests/test_kernel_direct.py

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -108,19 +108,6 @@ async def test_direct_debug_request(kernel):
108108
assert reply["header"]["msg_type"] == "debug_reply"
109109

110110

111-
@pytest.mark.skip("Shell streams don't exist anymore")
112-
async def test_deprecated_features(kernel):
113-
with warnings.catch_warnings():
114-
warnings.simplefilter("ignore", DeprecationWarning)
115-
header = kernel._parent_header
116-
assert isinstance(header, dict)
117-
shell_streams = kernel.shell_streams
118-
assert len(shell_streams) == 1
119-
assert shell_streams[0] == kernel.shell_stream
120-
warnings.simplefilter("ignore", RuntimeWarning)
121-
kernel.shell_streams = [kernel.shell_stream, kernel.shell_stream]
122-
123-
124111
async def test_process_control(kernel):
125112
from jupyter_client.session import DELIM
126113

@@ -142,12 +129,6 @@ async def test_dispatch_shell(kernel):
142129
await kernel.process_shell_message(msg)
143130

144131

145-
@pytest.mark.skip("kernelbase.do_one_iteration doesn't exist anymore")
146-
async def test_do_one_iteration(kernel):
147-
kernel.msg_queue = asyncio.Queue()
148-
await kernel.do_one_iteration()
149-
150-
151132
async def test_publish_debug_event(kernel):
152133
kernel._publish_debug_event({})
153134

@@ -160,7 +141,7 @@ async def test_send_interrupt_children(kernel):
160141
kernel._send_interrupt_children()
161142

162143

163-
# TODO: this causes deadlock
164-
# async def test_direct_usage_request(kernel):
165-
# reply = await kernel.test_control_message("usage_request", {})
166-
# assert reply['header']['msg_type'] == 'usage_reply'
144+
@pytest.mark.skip(reason="this causes deadlock")
145+
async def test_direct_usage_request(kernel):
146+
reply = await kernel.test_control_message("usage_request", {})
147+
assert reply["header"]["msg_type"] == "usage_reply"

0 commit comments

Comments
 (0)