From fff924d233602c80fcef87a4f51fececf391f211 Mon Sep 17 00:00:00 2001 From: Matthias Bussonnier Date: Mon, 16 Aug 2021 20:18:30 -0700 Subject: [PATCH] Remove Nose skipIf in favor of pytest --- ipykernel/tests/test_message_spec.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ipykernel/tests/test_message_spec.py b/ipykernel/tests/test_message_spec.py index a0cac9932..bfa81ca96 100644 --- a/ipykernel/tests/test_message_spec.py +++ b/ipykernel/tests/test_message_spec.py @@ -9,7 +9,10 @@ from queue import Empty import nose.tools as nt -from nose.plugins.skip import SkipTest + +import pytest + +import jupyter_client from traitlets import ( HasTraits, TraitError, Bool, Unicode, Dict, Integer, List, Enum @@ -483,10 +486,12 @@ def test_connect_request(): validate_message(reply, 'connect_reply', msg_id) +@pytest.mark.skipif( + jupyter_client.version_info < (5, 0), + reason="earlier Jupyter Client don't have comm_info", +) def test_comm_info_request(): flush_channels() - if not hasattr(KC, 'comm_info'): - raise SkipTest() msg_id = KC.comm_info() reply = get_reply(KC, msg_id, TIMEOUT) validate_message(reply, 'comm_info_reply', msg_id)