Skip to content

Commit 38ff54c

Browse files
committed
ipykernel 7 support - take 2
1 parent 40de02a commit 38ff54c

File tree

1 file changed

+7
-16
lines changed

1 file changed

+7
-16
lines changed

ipyparallel/engine/app.py

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -720,17 +720,13 @@ def send_with_metadata(
720720
kernel_kwargs["control_thread"] = control_thread = ControlThread(
721721
daemon=True
722722
)
723-
if ipykernel.version_info >= (7,):
724-
kernel_kwargs["shell_socket"] = zmq.asyncio.Socket(shell_socket)
725-
kernel_kwargs["control_socket"] = zmq.asyncio.Socket(control_socket)
726-
else:
727-
# Kernel.start starts control thread in kernel 7
728-
control_thread.start()
729-
kernel_kwargs["control_stream"] = zmqstream.ZMQStream(
730-
control_socket, control_thread.io_loop
731-
)
732723

733-
kernel_kwargs["shell_streams"] = [zmqstream.ZMQStream(shell_socket)]
724+
control_thread.start()
725+
kernel_kwargs["control_stream"] = zmqstream.ZMQStream(
726+
control_socket, control_thread.io_loop
727+
)
728+
729+
kernel_kwargs["shell_streams"] = [zmqstream.ZMQStream(shell_socket)]
734730

735731
self.kernel = Kernel.instance(
736732
parent=self,
@@ -954,12 +950,7 @@ def initialize(self, argv=None):
954950
self.forward_logging()
955951

956952
def init_signal(self):
957-
if ipykernel.version_info >= (7,):
958-
# ipykernel 7 changes SIGINT handling
959-
# to the app instead of the kernel
960-
self.kernel_app.init_signal()
961-
else:
962-
signal.signal(signal.SIGINT, self._signal_sigint)
953+
signal.signal(signal.SIGINT, self._signal_sigint)
963954
signal.signal(signal.SIGTERM, self._signal_stop)
964955

965956
def _signal_sigint(self, sig, frame):

0 commit comments

Comments
 (0)