Skip to content

Commit 87ec808

Browse files
committed
hook up control thread in ipykernel 6
1 parent b32c641 commit 87ec808

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

ipyparallel/engine/app.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -723,12 +723,18 @@ def send_with_metadata(
723723

724724
kernel_kwargs = {}
725725
if ipykernel.version_info >= (6,):
726-
kernel_kwargs["control_thread"] = ControlThread(daemon=True)
726+
kernel_kwargs["control_thread"] = control_thread = ControlThread(
727+
daemon=True
728+
)
727729
if ipykernel.version_info >= (7,):
728730
kernel_kwargs["shell_socket"] = zmq.asyncio.Socket(shell_socket)
729731
kernel_kwargs["control_socket"] = zmq.asyncio.Socket(control_socket)
730732
else:
731-
kernel_kwargs["control_stream"] = zmqstream.ZMQStream(control_socket)
733+
# Kernel.start starts control thread in kernel 7
734+
control_thread.start()
735+
kernel_kwargs["control_stream"] = zmqstream.ZMQStream(
736+
control_socket, control_thread.io_loop
737+
)
732738

733739
kernel_kwargs["shell_streams"] = [zmqstream.ZMQStream(shell_socket)]
734740

0 commit comments

Comments
 (0)