Skip to content

Commit 91d4bf2

Browse files
committed
add missing data_files for labextension
1 parent b7f1705 commit 91d4bf2

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,12 @@ jobs:
3030
- name: verify wheel
3131
run: |
3232
cd dist
33-
pip install ./*.whl
33+
pip install ./*.whl jupyterlab==3.*
3434
ipcluster --help-all
3535
ipcontroller --help-all
3636
ipengine --help-all
37+
jupyter labextension list 2>&1 | grep ipyparallel
38+
jupyter server extension list 2>&1 | grep ipyparallel
3739
3840
- name: Publish to PyPI
3941
if: startsWith(github.ref, 'refs/tags/')

setup.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,17 @@ def run(self):
6161
readme = f.read()
6262

6363
try:
64-
from jupyter_packaging import wrap_installers, npm_builder
64+
from jupyter_packaging import wrap_installers, npm_builder, get_data_files
65+
66+
data_files = get_data_files(data_files_spec)
6567

6668
builder = npm_builder()
6769
cmdclass = wrap_installers(pre_develop=builder, pre_dist=builder)
6870
except ImportError:
6971
from setuptools.command.build_py import build_py
7072

73+
data_files = {} # ignored
74+
7175
class NeedsJupyterPackaging(build_py):
7276
def run(self):
7377
raise ImportError(
@@ -87,11 +91,12 @@ def run(self):
8791
version=version_ns["__version__"],
8892
packages=setuptools.find_packages(),
8993
description="Interactive Parallel Computing with IPython",
94+
data_files=data_files,
9095
long_description=readme,
9196
long_description_content_type="text/markdown",
9297
author="IPython Development Team",
9398
author_email="[email protected]",
94-
url="http://ipython.org",
99+
url="https://ipython.org",
95100
license="BSD",
96101
platforms="Linux, Mac OS X, Windows",
97102
keywords=["Interactive", "Interpreter", "Shell", "Parallel"],

0 commit comments

Comments
 (0)