Merge pull request #638 from Bodo-inc/sahil/fix-view-bug-and-passthrough-flags

Pass through `kwargs` in `Client.broadcast_view()`

Author: minrk

ipyparallel/client/client.py

@@ -2085,6 +2085,7 @@ def broadcast_view(self, targets='all', is_coalescing=False, **kwargs):
             client=self,
             socket=self._broadcast_stream,
             targets=targets,
+            **kwargs,
         )
         bcast_view.is_coalescing = is_coalescing
         return bcast_view

ipyparallel/client/view.py

@@ -400,8 +400,8 @@ class DirectView(View):
 
     """
 
-    def __init__(self, client=None, socket=None, targets=None):
-        super().__init__(client=client, socket=socket, targets=targets)
+    def __init__(self, client=None, socket=None, targets=None, **flags):
+        super().__init__(client=client, socket=socket, targets=targets, **flags)
 
     @property
     def importer(self):

ipyparallel/tests/test_view.py

@@ -929,3 +929,14 @@ def func(x):
         res = view.apply_async(func, 5)
         assert res.get(timeout=10) == []
         view.use_pickle()
+
+    def test_block_kwarg(self):
+        """
+        Tests that kwargs such as 'block' can be
+        specified when creating a view, in this
+        case a BroadcastView
+        """
+        view = self.client.broadcast_view(block=True)
+        assert view.block == True
+        # Execute something as a sanity check
+        view.execute("5", silent=False)