Skip to content

Commit f47a6e3

Browse files
committed
Run tests with ip=*
make sure it's covered
1 parent 3e48611 commit f47a6e3

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ jobs:
4545
tornado: "5.1.1"
4646
- python: "3.6"
4747
- python: "3.7"
48+
controller_ip: "*"
4849
- python: "3.8"
4950
mpi: true
5051
- python: "3.9"
@@ -59,6 +60,11 @@ jobs:
5960
~/conda
6061
key: conda
6162

63+
- name: Set environment variables
64+
if: matrix.controller_ip
65+
run: |
66+
echo "IPP_CONTROLLER_IP=${{ matrix.controller_ip }}" >> $GITHUB_ENV
67+
6268
- name: Install Python (conda) ${{ matrix.python }}
6369
if: matrix.mpi
6470
run: |

ipyparallel/tests/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ def __str__(self):
6868
'--ping=250',
6969
'--dictdb',
7070
]
71+
if os.environ.get("IPP_CONTROLLER_IP"):
72+
cp.cmd_and_args.append(f"--ip={os.environ['IPP_CONTROLLER_IP']}")
7173
cp.start()
7274
launchers.append(cp)
7375
tic = time.time()

0 commit comments

Comments
 (0)