Skip to content

Commit a533526

Browse files
authored
Merge pull request #37 from ir-engine/IR-9383-Merge-SourceComponent-and-NodeIDComponent-into-UUIDComponent
refactor: replace NodeIDComponent with UUIDComponent in examples and …
2 parents d4bbf72 + b42d5a0 commit a533526

File tree

4 files changed

+7
-12
lines changed

4 files changed

+7
-12
lines changed

src/examples/ShadowExample.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { Entity, getComponent, setComponent } from '@ir-engine/ecs'
2-
import { NodeIDComponent } from '@ir-engine/engine/src/gltf/NodeIDComponent'
1+
import { Entity, getComponent, setComponent, UUIDComponent } from '@ir-engine/ecs'
32
import { RenderSettingsComponent } from '@ir-engine/engine/src/scene/components/RenderSettingsComponent'
43
import { ShadowComponent } from '@ir-engine/engine/src/scene/components/ShadowComponent'
54
import {
@@ -25,7 +24,7 @@ export default function ShadowExampleEntry(props: { sceneEntity: Entity }) {
2524

2625
useEffect(() => {
2726
setComponent(settingsEntity, RenderSettingsComponent, {
28-
primaryLight: getComponent(directionalLightEntity, NodeIDComponent)
27+
primaryLight: getComponent(directionalLightEntity, UUIDComponent).entityID
2928
}) // required for CSM
3029
setComponent(platformEntity, TransformComponent, {
3130
position: new Vector3(0, -0.5, 0),

src/examples/componentExamples/componentExamples.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
} from '@ir-engine/ecs'
1414
import { LoopAnimationComponent } from '@ir-engine/engine/src/avatar/components/LoopAnimationComponent'
1515
import { GLTFComponent } from '@ir-engine/engine/src/gltf/GLTFComponent'
16-
import { NodeIDComponent } from '@ir-engine/engine/src/gltf/NodeIDComponent'
1716
import {
1817
InteractableComponent,
1918
XRUIActivationType
@@ -26,7 +25,7 @@ import { PrimitiveGeometryComponent } from '@ir-engine/engine/src/scene/componen
2625
import { SDFComponent } from '@ir-engine/engine/src/scene/components/SDFComponent'
2726
import { SceneDynamicLoadComponent } from '@ir-engine/engine/src/scene/components/SceneDynamicLoadComponent'
2827
import { ShadowComponent } from '@ir-engine/engine/src/scene/components/ShadowComponent'
29-
import { SourceComponent } from '@ir-engine/engine/src/scene/components/SourceComponent'
28+
3029
import { SplineComponent } from '@ir-engine/engine/src/scene/components/SplineComponent'
3130
import { SplineTrackComponent } from '@ir-engine/engine/src/scene/components/SplineTrackComponent'
3231
import { Heuristic, VariantComponent } from '@ir-engine/engine/src/scene/components/VariantComponent'
@@ -228,7 +227,6 @@ export const subComponentExamples = [
228227
useEffect(() => {
229228
setComponent(entity, NameComponent, 'Particle-Example')
230229
setComponent(entity, ParticleSystemComponent)
231-
setComponent(entity, SourceComponent, parent)
232230
setVisibleComponent(entity, true)
233231
getComponent(entity, TransformComponent).position.set(0, 2, 0)
234232
}, [])
@@ -430,7 +428,7 @@ export const subComponentExamples = [
430428
callbacks: [
431429
{
432430
callbackID: LinkComponent.linkCallbackName,
433-
target: getComponent(entity, NodeIDComponent)
431+
target: getComponent(entity, UUIDComponent).entityID
434432
}
435433
]
436434
})

src/examples/mountPoint.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
removeEntity,
1313
setComponent
1414
} from '@ir-engine/ecs'
15-
import { NodeIDComponent } from '@ir-engine/engine/src/gltf/NodeIDComponent'
1615
import {
1716
InteractableComponent,
1817
XRUIVisibilityOverride
@@ -52,7 +51,7 @@ export default function MountPointEntry() {
5251
setVisibleComponent(geometryEntity, true)
5352
setComponent(geometryEntity, MeshComponent, new Mesh(new CylinderGeometry(), new MeshStandardMaterial()))
5453

55-
const entity = NodeIDComponent.create(sceneEntity, UUIDComponent.generate())
54+
const entity = UUIDComponent.create(sceneEntity)
5655
setComponent(entity, TransformComponent, { position: new Vector3(2, 0.4, 2) })
5756
setComponent(entity, EntityTreeComponent, { parentEntity: sceneEntity })
5857
setComponent(entity, NameComponent, 'Mount-Point-Example')
@@ -62,7 +61,7 @@ export default function MountPointEntry() {
6261
callbacks: [
6362
{
6463
callbackID: MountPointComponent.mountCallbackName,
65-
target: getComponent(entity, NodeIDComponent)
64+
target: getComponent(entity, UUIDComponent).entityID
6665
}
6766
],
6867
uiInteractable: true,

src/examples/utils/common/entityUtils.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,13 @@ import {
77
UUIDComponent
88
} from '@ir-engine/ecs'
99
import { GLTFComponent } from '@ir-engine/engine/src/gltf/GLTFComponent'
10-
import { NodeIDComponent } from '@ir-engine/engine/src/gltf/NodeIDComponent'
1110
import { useHookstate } from '@ir-engine/hyperflux'
1211
import { TransformComponent } from '@ir-engine/spatial'
1312
import { useEffect } from 'react'
1413

1514
export const setupEntity = (parent: Entity): Entity => {
1615
const sourceEntity = getAncestorWithComponents(parent, [GLTFComponent])
17-
const entity = NodeIDComponent.create(sourceEntity, UUIDComponent.generate())
16+
const entity = UUIDComponent.create(sourceEntity)
1817
setComponent(entity, TransformComponent)
1918
setComponent(entity, EntityTreeComponent, { parentEntity: parent })
2019
return entity

0 commit comments

Comments
 (0)