refactor(Command): modify and refactor CreatorEntity (improvement code style)

Author: saMahmoudzadeh

src/Creators/CreatorEntity.php

@@ -2,6 +2,7 @@
 
 namespace Eghamat24\DatabaseRepository\Creators;
 
+use Eghamat24\DatabaseRepository\Models\Enums\DataTypeEnum;
 use Illuminate\Support\Collection;
 use Eghamat24\DatabaseRepository\CustomMySqlQueries;
 
@@ -31,25 +32,21 @@ public function getExtendSection(): string
 
     public function createAttributes(): array
     {
-        $columns = $this->columns;
-        $entityStubsPath = $this->entityStubsPath;
-        $detectForeignKeys = $this->detectForeignKeys;
-        $tableName = $this->tableName;
         $attributes = [];
 
-        foreach ($columns as $_column) {
+        foreach ($this->columns as $_column) {
 
             $dataType = $this->getDataType($_column->COLUMN_TYPE, $_column->DATA_TYPE);
 
             $defaultValue = null;
             if ($_column->COLUMN_DEFAULT !== null) {
                 $defaultValue = $_column->COLUMN_DEFAULT;
 
-                if ($dataType == 'int') {
+                if ($dataType === DataTypeEnum::INTEGER_TYPE) {
                     $defaultValue = intval($defaultValue);
                 }
 
-                if ($dataType == self::BOOL_TYPE) {
+                if ($dataType === self::BOOL_TYPE) {
                     if (in_array($defaultValue, [0, '', "''"])) {
                         $defaultValue = 'false';
                     } elseif (in_array($defaultValue, [1, '1'])) {
@@ -59,29 +56,31 @@ public function createAttributes(): array
             }
 
             $columnString = $_column->COLUMN_NAME;
+
             if (!in_array($_column->COLUMN_DEFAULT, [null, 'NULL'])) {
                 $columnString .= ' = ' . $defaultValue;
             }
+
             if ($_column->IS_NULLABLE === 'YES') {
                 $columnString .= ' = null';
             }
 
             $attributes[$_column->COLUMN_NAME] =
                 $this->writeAttribute(
-                    $entityStubsPath,
+                    $this->entityStubsPath,
                     $columnString,
                     ($_column->IS_NULLABLE === 'YES' ? 'null|' : '') . $dataType
                 );
         }
 
-        if ($detectForeignKeys) {
-            $foreignKeys = $this->extractForeignKeys($tableName);
+        if ($this->detectForeignKeys) {
+            $foreignKeys = $this->extractForeignKeys($this->tableName);
 
             // Create Additional Attributes from Foreign Keys
             foreach ($foreignKeys as $_foreignKey) {
                 $attributes[$_column->COLUMN_NAME] =
                     $this->writeAttribute(
-                        $entityStubsPath,
+                        $this->entityStubsPath,
                         $_foreignKey->VARIABLE_NAME,
                         $_foreignKey->ENTITY_DATA_TYPE
                     );
@@ -93,73 +92,85 @@ public function createAttributes(): array
 
     public function createUses(): array
     {
-        return ["use Eghamat24\DatabaseRepository\Models\Entity\Entity;"];
+        return ['use Eghamat24\DatabaseRepository\Models\Entity\Entity;'];
     }
 
     public function createFunctions(): array
     {
-        $columns = $this->columns;
-        $entityStubsPath = $this->entityStubsPath;
-        $detectForeignKeys = $this->detectForeignKeys;
-        $tableName = $this->tableName;
         $settersAndGetters = [];
-        foreach ($columns as $_column) {
+
+        foreach ($this->columns as $_column) {
             $dataType = $this->getDataType($_column->COLUMN_TYPE, $_column->DATA_TYPE);
 
             $settersAndGetters['get' . ucwords($_column->COLUMN_NAME)] =
                 $this->writeAccessors(
-                    $entityStubsPath,
+                    $this->entityStubsPath,
                     $_column->COLUMN_NAME,
                     ($_column->IS_NULLABLE === 'YES' ? 'null|' : '') . $dataType,
                     'getter'
                 );
+
             $settersAndGetters['set' . ucwords($_column->COLUMN_NAME)] =
                 $this->writeAccessors(
-                    $entityStubsPath,
+                    $this->entityStubsPath,
                     $_column->COLUMN_NAME,
                     ($_column->IS_NULLABLE === 'YES' ? 'null|' : '') . $dataType,
                     'setter'
                 );
 
         }
-        if ($detectForeignKeys) {
-            $foreignKeys = $this->extractForeignKeys($tableName);
+
+        if ($this->detectForeignKeys) {
+            $foreignKeys = $this->extractForeignKeys($this->tableName);
 
             // Create Additional Setters and Getters from Foreign keys
             foreach ($foreignKeys as $_foreignKey) {
+
                 $settersAndGetters['get' . ucwords($_foreignKey->COLUMN_NAME)] =
                     $this->writeAccessors(
-                        $entityStubsPath,
+                        $this->entityStubsPath,
                         $_foreignKey->VARIABLE_NAME,
                         $_foreignKey->ENTITY_DATA_TYPE,
                         'getter'
                     );
+
                 $settersAndGetters['set' . ucwords($_foreignKey->COLUMN_NAME)] =
                     $this->writeAccessors(
-                        $entityStubsPath,
+                        $this->entityStubsPath,
                         $_foreignKey->VARIABLE_NAME,
                         $_foreignKey->ENTITY_DATA_TYPE,
                         'setter'
                     );
             }
         }
+
         return $settersAndGetters;
     }
 
     private function writeAttribute(string $entityStubsPath, string $attributeName, string $attributeType): string
     {
         $attributeStub = file_get_contents($entityStubsPath . 'attribute.stub');
-        return str_replace(['{{ AttributeType }}', '{{ AttributeName }}'],
-            [$attributeType, $attributeName],
-            $attributeStub);
+
+        $replaceMapping = [
+            '{{ AttributeType }}' => $attributeType,
+            '{{ AttributeName }}' => $attributeName,
+        ];
+
+        return str_replace(array_keys($replaceMapping), array_values($replaceMapping), $attributeStub);
     }
 
     private function writeAccessors(string $entityStubsPath, string $attributeName, string $attributeType, string $type): string
     {
         $accessorStub = file_get_contents($entityStubsPath . $type . '.stub');
-        return str_replace(['{{ AttributeType }}', '{{ AttributeName }}', '{{ GetterName }}', '{{ SetterName }}'],
-            [$attributeType, $attributeName, ucfirst($attributeName), ucfirst($attributeName)],
-            $accessorStub);
+
+        $replaceMapping = [
+            '{{ AttributeType }}' => $attributeType,
+            '{{ AttributeName }}' => $attributeName,
+            '{{ GetterName }}' => ucfirst($attributeName),
+            '{{ SetterName }}' => ucfirst($attributeName)
+        ];
+
+        return str_replace(array_keys($replaceMapping), array_values($replaceMapping), $accessorStub);
     }
 
     public function getNameSpace(): string