[Encoding][NFC] Use assemblyFormat for testing encodings. (#20520)

Signed-off-by: hanhanW <[email protected]>

Author: hanhanW

compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingAttrs.cpp

@@ -666,65 +666,12 @@ TestingEncodingAttr::cloneWithLayouts(ArrayRef<Attribute> layouts) const {
   return TestingEncodingAttr::get(ctx, ArrayAttr::get(ctx, layouts));
 }
 
-Attribute UnspecializedEncodingAttr::parse(AsmParser &p, Type type) {
-  if (failed(p.parseLess())) {
-    return {};
-  }
-  IntegerAttr seed;
-  if (failed(p.parseAttribute(seed))) {
-    return {};
-  }
-  if (failed(p.parseGreater())) {
-    return {};
-  }
-  return get(p.getContext(), seed);
-}
-
-void UnspecializedEncodingAttr::print(AsmPrinter &p) const {
-  auto &os = p.getStream();
-  os << "<";
-  p.printAttributeWithoutType(getSeed());
-  os << ">";
-}
-
 Attribute
 UnspecializedEncodingAttr::cloneWithSimplifiedConfig(DictionaryAttr) const {
   MLIRContext *ctx = getContext();
   return SpecializedEncodingAttr::get(ctx, getSeed(), /*type=*/{});
 }
 
-Attribute SpecializedEncodingAttr::parse(AsmParser &p, Type type) {
-  if (failed(p.parseLess())) {
-    return {};
-  }
-
-  IntegerAttr seed;
-  if (failed(p.parseAttribute(seed))) {
-    return {};
-  }
-
-  TypeAttr typeAttr;
-  if (succeeded(p.parseOptionalComma()) && failed(p.parseAttribute(typeAttr))) {
-    return {};
-  }
-
-  if (failed(p.parseGreater())) {
-    return {};
-  }
-  return get(p.getContext(), seed, typeAttr);
-}
-
-void SpecializedEncodingAttr::print(AsmPrinter &p) const {
-  auto &os = p.getStream();
-  os << "<";
-  p.printAttributeWithoutType(getSeed());
-  if (auto typeAttr = getType()) {
-    os << ", ";
-    p.printAttribute(typeAttr);
-  }
-  os << ">";
-}
-
 Attribute SpecializedEncodingAttr::getLayout(RankedTensorType type) const {
   MLIRContext *ctx = getContext();
   return get(ctx, getSeed(), TypeAttr::get(type.dropEncoding()));

compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingAttrs.td

@@ -369,24 +369,21 @@ def UnspecializedEncodingAttr :
       ]>
     ]> {
   let mnemonic = "unspecialized_encoding";
+  let assemblyFormat = "`<` $seed `>`";
 
   let summary = "An attribute that indicates the encoding is not yet specialized";
 
   let description = [{
     This attribute indicates this is an unspecialized encoding. It implements
-    very basic interface methods of EncodingLayoutResolverAttrInterface that converts
-    it to the SpecializeEncodingAttr during encoding specialization. It is
-    mainly for testing purpose as some transformations do not depend on actual
-    dialects that implement the attribute interface.
-  }];
+    very basic interface methods of EncodingLayoutResolverAttrInterface that
+    converts it to the SpecializeEncodingAttr during encoding specialization.
+    It is mainly for testing purpose as some transformations do not depend on
+    actual dialects that implement the attribute interface.
 
-  let parameters = (ins
-    AttrParameter<"IntegerAttr", "The seed that attached on the attribute. "
-    "Different seed values indicate different layouts.">:$seed
-  );
+    Different seed values indicate different layouts.
+  }];
 
-  let hasCustomAssemblyFormat = 1;
-  let genVerifyDecl = 0;
+  let parameters = (ins "int32_t":$seed);
 }
 
 def SpecializedEncodingAttr :
@@ -397,6 +394,7 @@ def SpecializedEncodingAttr :
       IREEEncoding_SerializableEncodingAttrInterface
     ]> {
   let mnemonic = "specialized_encoding";
+  let assemblyFormat = "`<` $seed (`,` $type^)? `>`";
 
   let summary = "An attribute that indicates the encoding is specialized";
 
@@ -405,16 +403,14 @@ def SpecializedEncodingAttr :
     type. The attribute denotes the layout of the type. Different seed values
     indicate different layouts, which can be used to emulate different encoding
     attributes.
+
+    Different seed values indicate different layouts.
   }];
 
   let parameters = (ins
-    AttrParameter<"IntegerAttr", "The seed that attached on the attribute. "
-    "Different seed values indicate different layouts.">:$seed,
-    AttrParameter<"TypeAttr", "">:$type
+    "int32_t":$seed,
+    OptionalParameter<"TypeAttr", "">:$type
   );
-
-  let hasCustomAssemblyFormat = 1;
-  let genVerifyDecl = 0;
 }
 
 #endif // IREE_DIALECT_ENCODING_ATTRS