Skip to content

Commit 84f18ff

Browse files
kuharclaude
andauthored
[CMake][Python] Bump minimum CMake version to 3.26 (#23607)
CMake 3.26 added FindPython's `Development.SABIModule` component, which is required for building Stable ABI (abi3). With this minimum version, we can unconditionally request `SABIModule` upfront in the Python `find_package` calls, before deciding whether to enable abi3. This is appealing because the SABI module must be found early and cannot be deferred to after the abi3 option is resolved; otherwise we need the user to decide through cmake flags. CMake 3.26 availability: pip install cmake: 4.2.3 Homebrew: 4.2.3 Chocolatey (Windows CI): 4.2.3 Ubuntu 24.04 (apt): 3.28.3 Ubuntu 22.04 (apt): 3.22.1 (use pip or Kitware APT repo) Debian 12 bookworm (apt): 3.25.1 (3.31.6 in backports) ci-extra: all --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4e8dde4 commit 84f18ff

18 files changed

+33
-14
lines changed

.github/workflows/build_clang_tidy.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ jobs:
4242
with:
4343
submodules: true
4444

45+
- name: Install Python requirements
46+
run: python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
4547
- name: "Setting up CMake"
4648
run: |
4749
source ./build_tools/cmake/setup_build.sh

.github/workflows/ci_linux_arm64_clang.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ jobs:
3232
with:
3333
submodules: true
3434
- name: Install Python requirements
35-
run: python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
35+
run: |
36+
python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
37+
python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
3638
# TODO(#18557): enable sccache (watching for network bandwidth charges
3739
# between the cache server and AWS VMs)
3840
- name: CMake - configure

.github/workflows/ci_linux_x64_clang.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ jobs:
3030
with:
3131
submodules: true
3232
- name: Install Python requirements
33-
run: python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
33+
run: |
34+
python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
35+
python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
3436
- name: Build IREE
3537
run: |
3638
source ./build_tools/cmake/setup_sccache.sh

.github/workflows/ci_linux_x64_clang_asan.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ jobs:
2323
with:
2424
submodules: true
2525
- name: Install Python requirements
26-
run: python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
26+
run: |
27+
python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
28+
python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
2729
- name: Build and test with ASan
2830
env:
2931
# Use a modern clang explicitly.

.github/workflows/ci_linux_x64_clang_byollvm.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ jobs:
2626
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2727
with:
2828
submodules: true
29+
- name: Install Python requirements
30+
run: python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
2931
- name: "Building and testing with bring-your-own-LLVM"
3032
run: ./build_tools/cmake/build_and_test_byo_llvm.sh
3133

.github/workflows/ci_linux_x64_clang_debug.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ jobs:
3535
with:
3636
submodules: true
3737
- name: Install Python requirements
38-
run: python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
38+
run: |
39+
python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
40+
python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
3941
- name: Build IREE
4042
env:
4143
CMAKE_BUILD_TYPE: Debug

.github/workflows/ci_linux_x64_clang_tsan.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ jobs:
3434
with:
3535
submodules: true
3636
- name: Install Python requirements
37-
run: python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
37+
run: |
38+
python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
39+
python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
3840
- name: Build and test with TSan
3941
env:
4042
# Use a modern clang explicitly.

.github/workflows/ci_linux_x64_clang_ubsan.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ jobs:
2323
with:
2424
submodules: true
2525
- name: Install Python requirements
26-
run: python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
26+
run: |
27+
python3 -m pip install -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
28+
python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
2729
- name: Build and test with UBSan
2830
env:
2931
# Use a modern clang explicitly.

.github/workflows/ci_linux_x64_gcc.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ jobs:
2828
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2929
with:
3030
submodules: true
31+
- name: Install Python requirements
32+
run: python3 -m pip install -r ./build_tools/github_actions/ci_requirements.txt
3133
- name: "Building IREE with gcc"
3234
env:
3335
CC: gcc-11

.github/workflows/clang_tidy.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ jobs:
7171
echo "$HOME/.local/bin" >> "$GITHUB_PATH"
7272
export PATH="$HOME/.local/bin:$PATH"
7373
uv pip install --system -r ./runtime/bindings/python/iree/runtime/build_requirements.txt
74+
uv pip install --system -r ./build_tools/github_actions/ci_requirements.txt
7475
7576
- name: Generate compilation database (compile_commands.json)
7677
run: |

0 commit comments

Comments
 (0)