Skip to content

Commit 8c86c23

Browse files
benvanikElias Joseph
authored andcommitted
Deleting iree_input dialect. (#20256)
The dialect is no longer used and we encourage projects to lower directly to the appropriate HAL and flow ops. The input dialect predates MLIR's versioning mechanism and we weren't versioning iree_input manually anyway so it was just adding an extra layer of goo - if in the future we want to version the input ops in the internal dialects we can do so using MLIR's versioning mechanism. The IREEImportPublic pass is still used for func->util conversion today and will be removed in a follow-up PR. Signed-off-by: Elias Joseph <[email protected]>
1 parent 34c4ca1 commit 8c86c23

File tree

35 files changed

+11
-4038
lines changed

35 files changed

+11
-4038
lines changed

compiler/src/iree/compiler/InputConversion/Common/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ iree_compiler_cc_library(
6363
"//compiler/src/iree/compiler/Dialect/Util/Transforms",
6464
"//compiler/src/iree/compiler/Pipelines:Options",
6565
"//compiler/src/iree/compiler/Utils",
66-
"//llvm-external-projects/iree-dialects:IREEInputDialect",
6766
"@llvm-project//llvm:Support",
6867
"@llvm-project//mlir:ArithDialect",
6968
"@llvm-project//mlir:FuncDialect",

compiler/src/iree/compiler/InputConversion/Common/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ iree_cc_library(
4747
DEPS
4848
::PassHeaders
4949
::PassesIncGen
50-
IREEInputDialect
5150
LLVMSupport
5251
MLIRArithDialect
5352
MLIRFuncDialect

compiler/src/iree/compiler/InputConversion/Common/IREEImportPublic.cpp

Lines changed: 8 additions & 350 deletions
Large diffs are not rendered by default.

compiler/src/iree/compiler/InputConversion/Common/test/iree_import_public.mlir

Lines changed: 0 additions & 410 deletions
Large diffs are not rendered by default.

compiler/src/iree/compiler/Tools/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ iree_compiler_cc_library(
7171
"//compiler/src/iree/compiler/Pipelines",
7272
"//compiler/src/iree/compiler/Preprocessing:Passes",
7373
"//compiler/src/iree/compiler/Preprocessing/TransformExtensions:PreprocessingExtensions",
74-
"//llvm-external-projects/iree-dialects:IREEInputDialect",
7574
"//llvm-external-projects/iree-dialects:IREELinalgTransformDialect",
7675
"//llvm-external-projects/iree-dialects:IREELinalgTransformDialectPasses",
7776
"@llvm-project//mlir:IR",

compiler/src/iree/compiler/Tools/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ iree_cc_library(
2424
"init_iree_dialects.h"
2525
"init_iree_passes.h"
2626
DEPS
27-
IREEInputDialect
2827
IREELinalgTransformDialect
2928
IREELinalgTransformDialectPasses
3029
MLIRIR

compiler/src/iree/compiler/Tools/init_iree_dialects.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#ifndef IREE_COMPILER_TOOLS_INIT_IREE_DIALECTS_H_
1313
#define IREE_COMPILER_TOOLS_INIT_IREE_DIALECTS_H_
1414

15-
#include "iree-dialects/Dialect/Input/InputDialect.h"
1615
#include "iree-dialects/Dialect/LinalgTransform/Passes.h"
1716
#include "iree/compiler/Codegen/Dialect/CPU/IR/IREECPUDialect.h"
1817
#include "iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenDialect.h"
@@ -48,7 +47,6 @@ inline void registerIreeDialects(DialectRegistry &registry) {
4847
IREE::HAL::Inline::HALInlineDialect,
4948
IREE::HAL::Loader::HALLoaderDialect,
5049
IREE::IO::Parameters::IOParametersDialect,
51-
IREE::Input::IREEInputDialect,
5250
IREE::LinalgExt::IREELinalgExtDialect,
5351
IREE::Encoding::IREEEncodingDialect,
5452
IREE::Stream::StreamDialect,

docs/website/docs/reference/mlir-dialects/index.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,4 @@ Dialect | Description
3434
[VM](./VM.md) | Represents operations against an abstract virtual machine
3535
[VMVX](./VMVX.md) | Virtual Machine Vector Extensions
3636

37-
## IREE public dialects
38-
39-
The ops in these dialects are legal to include in compiler inputs. The sources
40-
for these dialects can be found in the
41-
[`llvm-external-projects/iree-dialects/` directory](https://github.com/iree-org/iree/tree/main/llvm-external-projects/iree-dialects)
42-
that is designed to be used from other projects via LLVM's external projects
43-
mechanism.
44-
45-
Dialect | Description
46-
------------------------------------| -----------
47-
[IREEInput](./IREEInput.md) | Structural ops legal as input to IREE's compiler
48-
4937
[^1]: Hardware Abstraction Layer

docs/website/generate_extra_files.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,6 @@ for f in ${BUILD_DOCS_PROCESSED_DIR}/*Dialect.md; do
5454
mv "$f" "${f/%Dialect.md/.md}"
5555
done
5656

57-
# Rename iree-dialect files.
58-
mv "${BUILD_DOCS_PROCESSED_DIR}/InputOps.md" "${BUILD_DOCS_PROCESSED_DIR}/IREEInput.md"
59-
# mv "${BUILD_DOCS_PROCESSED_DIR}/StructuredTransformOpsExt.md" "${BUILD_DOCS_PROCESSED_DIR}/IREEStructuredTransformExt.md"
60-
6157
# Postprocess the dialect docs (e.g. making tweaks to the markdown source).
6258
python3 "${THIS_DIR}/postprocess_dialect_docs.py" "${BUILD_DOCS_PROCESSED_DIR}"
6359

docs/website/mkdocs.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,6 @@ nav:
185185
- Util: "reference/mlir-dialects/Util.md"
186186
- VM: "reference/mlir-dialects/VM.md"
187187
- VMVX: "reference/mlir-dialects/VMVX.md"
188-
# Dialects from llvm-external-projects/iree-dialects/
189-
- "Public dialects":
190-
- IREEInput: "reference/mlir-dialects/IREEInput.md"
191188
- "Other topics":
192189
- Glossary: "reference/glossary.md"
193190
- Optimization options: "reference/optimization-options.md"

0 commit comments

Comments
 (0)