Minor comment/style tweaks to the null HAL driver. (#18911)

Author: benvanik

.github/CODEOWNERS

@@ -32,7 +32,6 @@
 # Experimental
 # It's experimental, but we still don't want any old directory added here.
 /experimental/ @benvanik @stellaraccident
-/experimental/rocm/ @benvanik
 /experimental/web/ @ScottTodd
 /experimental/webgpu/ @benvanik @ScottTodd
 

runtime/src/iree/hal/drivers/null/README.md

@@ -17,8 +17,10 @@ fill (memset) you can often implement copy (memcpy) as well at the same time.
    `experimental/` folder if going in-tree.
 1. Find/replace `{Null}` with the friendly name of your driver (e.g. `Vulkan`).
 1. Find/replace `_null_` with the C name of your driver (e.g. `vulkan`).
+1. Find/replace `_NULL_` with the upper C name of your driver (e.g. `VULKAN`).
 1. Find/replace `// TODO(null):` with your github ID, your driver name, or a
    GitHub issue number tracking driver creation (e.g. `// TODO(#1234):`).
+1. Find/replace `iree/hal/drivers/null/` with your source path.
 
 ## Build Setup
 

runtime/src/iree/hal/drivers/null/allocator.c

@@ -8,6 +8,10 @@
 
 #include "iree/hal/drivers/null/buffer.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_allocator_t
+//===----------------------------------------------------------------------===//
+
 // TODO(null): use one ID per address space or pool - each shows as a different
 // track in tracing tools.
 #if IREE_TRACING_FEATURES & IREE_TRACING_FEATURE_ALLOCATION_TRACKING
@@ -33,6 +37,7 @@ iree_status_t iree_hal_null_allocator_create(
     iree_allocator_t host_allocator, iree_hal_allocator_t** out_allocator) {
   IREE_ASSERT_ARGUMENT(out_allocator);
   IREE_TRACE_ZONE_BEGIN(z0);
+  *out_allocator = NULL;
 
   iree_hal_null_allocator_t* allocator = NULL;
   IREE_RETURN_AND_END_ZONE_IF_ERROR(

runtime/src/iree/hal/drivers/null/allocator.h

@@ -10,6 +10,10 @@
 #include "iree/base/api.h"
 #include "iree/hal/api.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_allocator_t
+//===----------------------------------------------------------------------===//
+
 // Creates a {Null} buffer allocator used for persistent allocations.
 iree_status_t iree_hal_null_allocator_create(
     iree_allocator_t host_allocator, iree_hal_allocator_t** out_allocator);

runtime/src/iree/hal/drivers/null/buffer.c

@@ -6,6 +6,10 @@
 
 #include "iree/hal/drivers/null/buffer.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_buffer_t
+//===----------------------------------------------------------------------===//
+
 typedef struct iree_hal_null_buffer_t {
   iree_hal_buffer_t base;
   iree_hal_buffer_release_callback_t release_callback;
@@ -33,8 +37,8 @@ iree_status_t iree_hal_null_buffer_wrap(
     iree_hal_buffer_release_callback_t release_callback,
     iree_allocator_t host_allocator, iree_hal_buffer_t** out_buffer) {
   IREE_ASSERT_ARGUMENT(out_buffer);
-  *out_buffer = NULL;
   IREE_TRACE_ZONE_BEGIN(z0);
+  *out_buffer = NULL;
 
   iree_hal_null_buffer_t* buffer = NULL;
   IREE_RETURN_AND_END_ZONE_IF_ERROR(

runtime/src/iree/hal/drivers/null/buffer.h

@@ -10,6 +10,10 @@
 #include "iree/base/api.h"
 #include "iree/hal/api.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_buffer_t
+//===----------------------------------------------------------------------===//
+
 // Wraps a {Null} allocation in an iree_hal_buffer_t.
 iree_status_t iree_hal_null_buffer_wrap(
     iree_hal_allocator_t* allocator, iree_hal_memory_type_t memory_type,

runtime/src/iree/hal/drivers/null/channel.c

@@ -6,6 +6,10 @@
 
 #include "iree/hal/drivers/null/channel.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_channel_t
+//===----------------------------------------------------------------------===//
+
 typedef struct iree_hal_null_channel_t {
   iree_hal_resource_t resource;
   iree_allocator_t host_allocator;
@@ -34,8 +38,8 @@ iree_status_t iree_hal_null_channel_create(iree_hal_channel_params_t params,
                                            iree_allocator_t host_allocator,
                                            iree_hal_channel_t** out_channel) {
   IREE_ASSERT_ARGUMENT(out_channel);
-  *out_channel = NULL;
   IREE_TRACE_ZONE_BEGIN(z0);
+  *out_channel = NULL;
 
   iree_hal_null_channel_t* channel = NULL;
   IREE_RETURN_AND_END_ZONE_IF_ERROR(

runtime/src/iree/hal/drivers/null/channel.h

@@ -10,6 +10,10 @@
 #include "iree/base/api.h"
 #include "iree/hal/api.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_channel_t
+//===----------------------------------------------------------------------===//
+
 // Creates a {Null} HAL collective channel using the given |params|.
 iree_status_t iree_hal_null_channel_create(iree_hal_channel_params_t params,
                                            iree_allocator_t host_allocator,

runtime/src/iree/hal/drivers/null/command_buffer.c

@@ -10,6 +10,10 @@
 #include "iree/hal/drivers/null/channel.h"
 #include "iree/hal/drivers/null/executable.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_command_buffer_t
+//===----------------------------------------------------------------------===//
+
 typedef struct iree_hal_null_command_buffer_t {
   iree_hal_command_buffer_t base;
   iree_allocator_t host_allocator;
@@ -31,8 +35,8 @@ iree_status_t iree_hal_null_command_buffer_create(
     iree_allocator_t host_allocator,
     iree_hal_command_buffer_t** out_command_buffer) {
   IREE_ASSERT_ARGUMENT(out_command_buffer);
-  *out_command_buffer = NULL;
   IREE_TRACE_ZONE_BEGIN(z0);
+  *out_command_buffer = NULL;
 
   iree_hal_null_command_buffer_t* command_buffer = NULL;
   IREE_RETURN_AND_END_ZONE_IF_ERROR(

runtime/src/iree/hal/drivers/null/command_buffer.h

@@ -10,6 +10,10 @@
 #include "iree/base/api.h"
 #include "iree/hal/api.h"
 
+//===----------------------------------------------------------------------===//
+// iree_hal_null_command_buffer_t
+//===----------------------------------------------------------------------===//
+
 // Creates {Null} command buffer.
 iree_status_t iree_hal_null_command_buffer_create(
     iree_hal_allocator_t* device_allocator, iree_hal_command_buffer_mode_t mode,