Skip to content

Commit e3826d5

Browse files
authored
Change to <= dispatch count regression checks. (#19166)
This changes the equal check for dispatch regressions to a <= check. We should monitor the dispatch counts and update the golden values appropriately instead of failing on improvements. ci-exactly: build_packages, regression_test
1 parent 43d3d1a commit e3826d5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

experimental/benchmarks/sdxl/benchmark_sdxl_rocm.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ def test_sdxl_rocm_benchmark(
530530
goldentime_rocm_unet,
531531
"SDXL unet benchmark time should not regress",
532532
)
533-
check.equal(
533+
check.less_equal(
534534
unet_dispatch_count,
535535
goldendispatch_rocm_unet,
536536
"SDXL scheduled unet dispatch count should not regress",
@@ -546,7 +546,7 @@ def test_sdxl_rocm_benchmark(
546546
goldentime_rocm_punet_int8_fp16,
547547
"SDXL punet f16 benchmark time should not regress",
548548
)
549-
check.equal(
549+
check.less_equal(
550550
punet_int8_fp16_dispatch_count,
551551
goldendispatch_rocm_punet_int8_fp16,
552552
"SDXL punet f16 dispatch count should not regress",
@@ -561,7 +561,7 @@ def test_sdxl_rocm_benchmark(
561561
goldentime_rocm_punet_int8_fp8,
562562
"SDXL punet f8 benchmark time should not regress",
563563
)
564-
check.equal(
564+
check.less_equal(
565565
punet_int8_fp8_dispatch_count,
566566
goldendispatch_rocm_punet_int8_fp8,
567567
"SDXL punet f8 dispatch count should not regress",
@@ -576,7 +576,7 @@ def test_sdxl_rocm_benchmark(
576576
goldentime_rocm_clip,
577577
"SDXL prompt encoder benchmark time should not regress",
578578
)
579-
check.equal(
579+
check.less_equal(
580580
clip_dispatch_count,
581581
goldendispatch_rocm_clip,
582582
"SDXL prompt encoder dispatch count should not regress",
@@ -591,7 +591,7 @@ def test_sdxl_rocm_benchmark(
591591
goldentime_rocm_vae,
592592
"SDXL vae decode benchmark time should not regress",
593593
)
594-
check.equal(
594+
check.less_equal(
595595
vae_dispatch_count,
596596
goldendispatch_rocm_vae,
597597
"SDXL vae decode dispatch count should not regress",

0 commit comments

Comments
 (0)