Fix crash when using when using --finalize-memref-to-llvm (llvm#112433)

This patch fixes crash when attempting to convert uint to int address
space during finalize-memref-to-llvm by doing the following:

1. Add a check to verify that IntegerAttr is signed int before calling
IntegerAttr::getInt()
 2. Emit error when getMemRefAddressSpace returns a failure()

Closes  llvm#111242

---------

Co-authored-by: Christian Ulmann <[email protected]>

Author: 2 people

mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp

@@ -524,8 +524,11 @@ LLVMTypeConverter::getMemRefAddressSpace(BaseMemRefType type) const {
     return failure();
   if (!(*converted)) // Conversion to default is 0.
     return 0;
-  if (auto explicitSpace = llvm::dyn_cast_if_present<IntegerAttr>(*converted))
-    return explicitSpace.getInt();
+  if (auto explicitSpace = dyn_cast_if_present<IntegerAttr>(*converted)) {
+    if (explicitSpace.getType().isIndex() ||
+        explicitSpace.getType().isSignlessInteger())
+      return explicitSpace.getInt();
+  }
   return failure();
 }
 

mlir/lib/Conversion/MemRefToLLVM/AllocLikeConversion.cpp

@@ -74,6 +74,12 @@ std::tuple<Value, Value> AllocationOpLLVMLowering::allocateBufferManuallyAlign(
   MemRefType memRefType = getMemRefResultType(op);
   // Allocate the underlying buffer.
   Type elementPtrType = this->getElementPtrType(memRefType);
+  if (!elementPtrType) {
+    emitError(loc, "conversion of memref memory space ")
+        << memRefType.getMemorySpace()
+        << " to integer address space "
+           "failed. Consider adding memory space conversions.";
+  }
   LLVM::LLVMFuncOp allocFuncOp = getNotalignedAllocFn(
       getTypeConverter(), op->getParentWithTrait<OpTrait::SymbolTable>(),
       getIndexType());

mlir/test/Conversion/MemRefToLLVM/invalid-uint.mlir

@@ -0,0 +1,8 @@
+// RUN: mlir-opt %s -finalize-memref-to-llvm -verify-diagnostics
+
+// CHECK-LABEL: @invalid_int_conversion
+func.func @invalid_int_conversion() {
+     // expected-error@+1 {{conversion of memref memory space 1 : ui64 to integer address space failed. Consider adding memory space conversions.}}
+     %alloc = memref.alloc() {alignment = 64 : i64} : memref<10xf32, 1 : ui64> 
+    return
+}