Skip to content

Commit d60feae

Browse files
rupprechtMax191
authored andcommitted
[bazel][NFC] Avoid set for older bazel versions (llvm#170758)
The `set` type is only available on Bazel 8.1, which is newer than some projects. This gives some time for downstream users of LLVM to migrate to Bazel 8.1 or newer. e.g. https://github.com/openxla/xla/actions/runs/19943322161/job/57186478292
1 parent bedb335 commit d60feae

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

utils/bazel/configure.bzl

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ DEFAULT_TARGETS = [
2727
"XCore",
2828
]
2929

30-
3130
MAX_TRAVERSAL_STEPS = 1000000 # "big number" upper bound on total visited dirs
3231

3332
def _overlay_directories(repository_ctx):
@@ -44,7 +43,9 @@ def _overlay_directories(repository_ctx):
4443
for _ in range(MAX_TRAVERSAL_STEPS):
4544
rel_dir = stack.pop()
4645

47-
overlay_dirs = set()
46+
# TODO: `set()` is only available in bazel 8.1.
47+
# Use `set()` after downstream users are on more recent versions.
48+
overlay_dirs = {}
4849

4950
# Symlink overlay files, overlay dirs will be handled in future iterations.
5051
for entry in overlay_root.get_child(rel_dir).readdir():
@@ -53,7 +54,7 @@ def _overlay_directories(repository_ctx):
5354

5455
if entry.is_dir:
5556
stack.append(full_rel_path)
56-
overlay_dirs.add(name)
57+
overlay_dirs[name] = None
5758
else:
5859
src_path = overlay_root.get_child(full_rel_path)
5960
dst_path = target_root.get_child(full_rel_path)
@@ -62,7 +63,7 @@ def _overlay_directories(repository_ctx):
6263
# Symlink source dirs (if not themselves overlaid) and files.
6364
for src_entry in src_root.get_child(rel_dir).readdir():
6465
name = src_entry.basename
65-
if name in overlay_dirs:
66+
if name in overlay_dirs.keys():
6667
# Skip: overlay has a directory with this name
6768
continue
6869

0 commit comments

Comments
 (0)