Skip to content

Commit fd12e9a

Browse files
authored
[libc++][tests] Update XFAIL annotations for some tests on Windows (llvm#149124)
These tests still fail on Windows with clang-22, as reported in llvm#70225. This started failing due to the version bump to Clang 22.
1 parent 6c705d1 commit fd12e9a

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

libcxx/test/libcxx/fuzzing/random.pass.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// This test fails because Clang no longer enables -fdelayed-template-parsing
10-
// by default on Windows with C++20 (#69431).
11-
// XFAIL: msvc && (clang-18 || clang-19 || clang-20 || clang-21)
9+
// This doesn't work on Windows because in the MSVC UCRT headers the math.h is
10+
// actually intended to implement the full C++ spec requirements. For details
11+
// see https://github.com/llvm/llvm-project/issues/70225#issuecomment-1992528828
12+
// XFAIL: msvc
1213

1314
// UNSUPPORTED: c++03, c++11
1415

libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// This test fails because Clang no longer enables -fdelayed-template-parsing
10-
// by default on Windows with C++20 (#69431).
11-
// XFAIL: msvc && (clang-18 || clang-19 || clang-20 || clang-21)
9+
// This doesn't work on Windows because in the MSVC UCRT headers the math.h is
10+
// actually intended to implement the full C++ spec requirements. For details
11+
// see https://github.com/llvm/llvm-project/issues/70225#issuecomment-1992528828
12+
// XFAIL: msvc
1213

1314
// <math.h>
1415

libcxx/test/std/numerics/c.math/cmath.pass.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// This test fails because Clang no longer enables -fdelayed-template-parsing
10-
// by default on Windows with C++20 (#69431).
11-
// XFAIL: msvc && (clang-18 || clang-19 || clang-20 || clang-21)
9+
// This doesn't work on Windows because in the MSVC UCRT headers the math.h is
10+
// actually intended to implement the full C++ spec requirements. For details
11+
// see https://github.com/llvm/llvm-project/issues/70225#issuecomment-1992528828
12+
// XFAIL: msvc
1213

1314
// <cmath>
1415

0 commit comments

Comments
 (0)