Skip to content

Commit e22c383

Browse files
author
aofengli
authored
Merge pull request #333 from irisnet/fix/gon
replace base64.RawStdEncoding with base64.StdEncoding
2 parents a61dbef + 360645b commit e22c383

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

modules/nft/types/builder.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ var (
3030
ClassKeySchema = fmt.Sprintf("%s%s", Namespace, "schema")
3131
TokenKeyName = fmt.Sprintf("%s%s", Namespace, "name")
3232
TokenKeyURIhash = fmt.Sprintf("%s%s", Namespace, "uri_hash")
33+
34+
Base64 = base64.StdEncoding
3335
)
3436

3537
type (
@@ -70,7 +72,7 @@ func (cb ClassBuilder) BuildMetadata(class nft.Class) (string, error) {
7072
err := json.Unmarshal([]byte(metadata.Data), &kvals)
7173
if err != nil && IsIBCDenom(class.Id) {
7274
//when classData is not a legal json, there is no need to parse the data
73-
return base64.RawStdEncoding.EncodeToString([]byte(metadata.Data)), nil
75+
return Base64.EncodeToString([]byte(metadata.Data)), nil
7476
}
7577
//note: if metadata.Data is null, it may cause map to be redefined as nil
7678
if kvals == nil {
@@ -95,12 +97,12 @@ func (cb ClassBuilder) BuildMetadata(class nft.Class) (string, error) {
9597
if err != nil {
9698
return "", err
9799
}
98-
return base64.RawStdEncoding.EncodeToString(data), nil
100+
return Base64.EncodeToString(data), nil
99101
}
100102

101103
// Build create a class from ics721 packetData
102104
func (cb ClassBuilder) Build(classID, classURI, classData string) (nft.Class, error) {
103-
classDataBz, err := base64.RawStdEncoding.DecodeString(classData)
105+
classDataBz, err := Base64.DecodeString(classData)
104106
if err != nil {
105107
return nft.Class{}, err
106108
}
@@ -267,7 +269,7 @@ func (tb TokenBuilder) BuildMetadata(token nft.NFT) (string, error) {
267269
err := json.Unmarshal([]byte(nftMetadata.Data), &kvals)
268270
if err != nil && IsIBCDenom(token.ClassId) {
269271
//when nftMetadata is not a legal json, there is no need to parse the data
270-
return base64.RawStdEncoding.EncodeToString([]byte(nftMetadata.Data)), nil
272+
return Base64.EncodeToString([]byte(nftMetadata.Data)), nil
271273
}
272274
//note: if nftMetadata.Data is null, it may cause map to be redefined as nil
273275
if kvals == nil {
@@ -280,12 +282,12 @@ func (tb TokenBuilder) BuildMetadata(token nft.NFT) (string, error) {
280282
if err != nil {
281283
return "", err
282284
}
283-
return base64.RawStdEncoding.EncodeToString(data), nil
285+
return Base64.EncodeToString(data), nil
284286
}
285287

286288
// Build create a nft from ics721 packet data
287289
func (tb TokenBuilder) Build(classId, tokenId, tokenURI, tokenData string) (nft.NFT, error) {
288-
tokenDataBz, err := base64.RawStdEncoding.DecodeString(tokenData)
290+
tokenDataBz, err := Base64.DecodeString(tokenData)
289291
if err != nil {
290292
return nft.NFT{}, err
291293
}

modules/nft/types/builder_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package types
22

33
import (
4-
"encoding/base64"
54
"encoding/json"
65
"testing"
76

@@ -166,7 +165,7 @@ func TestClassBuilder_BuildMetadata(t *testing.T) {
166165
class.Data = any
167166

168167
got, err := cb.BuildMetadata(class)
169-
want := base64.RawStdEncoding.EncodeToString([]byte(tt.want))
168+
want := Base64.EncodeToString([]byte(tt.want))
170169
if (err != nil) != tt.wantErr {
171170
t.Errorf("ClassBuilder.BuildMetadata() error = %v, wantErr %v", err, tt.wantErr)
172171
return
@@ -229,7 +228,7 @@ func TestClassBuilder_Build(t *testing.T) {
229228
cdc: cdc,
230229
getModuleAddress: getModuleAddress,
231230
}
232-
classDataRaw := base64.RawStdEncoding.EncodeToString([]byte(tt.args.classData))
231+
classDataRaw := Base64.EncodeToString([]byte(tt.args.classData))
233232
result, err := cb.Build(classID, classURI, classDataRaw)
234233
if (err != nil) != tt.wantErr {
235234
t.Errorf("ClassBuilder.BuildMetadata() error = %v, wantErr %v", err, tt.wantErr)

0 commit comments

Comments
 (0)