Skip to content
This repository was archived by the owner on Jun 4, 2023. It is now read-only.

Commit efb67a3

Browse files
committed
removed explicit version checks of dependencies such as serpent
1 parent afe3860 commit efb67a3

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

docs/source/changelog.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ Change Log
55
**Pyro 4.79**
66

77
- cython compatibility fix
8+
- removed explicit version checks of dependencies such as serpent.
9+
This fixes crash error when dealing with prerelease versions that didn't match the pattern.
810

911

1012
**Pyro 4.78**

src/Pyro4/util.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -820,27 +820,16 @@ def get_serializer_by_id(sid):
820820
pass
821821
try:
822822
import serpent
823-
if '-' in serpent.__version__:
824-
ver = serpent.__version__.split('-', 1)[0]
825-
else:
826-
ver = serpent.__version__
827-
ver = tuple(map(int, ver.split(".")))
828-
if ver < (1, 27):
829-
raise RuntimeError("requires serpent 1.27 or later")
830823
_ser = SerpentSerializer()
831824
_serializers["serpent"] = _ser
832825
_serializers_by_id[_ser.serializer_id] = _ser
833826
except ImportError:
834827
log.warning("serpent serializer is not available")
835828
try:
836829
import msgpack
837-
if msgpack.version < (0, 5, 2):
838-
import warnings
839-
warnings.warn("msgpack serializer unavailable. requires msgpack 0.5.2+, found " + str(msgpack.version))
840-
else:
841-
_ser = MsgpackSerializer()
842-
_serializers["msgpack"] = _ser
843-
_serializers_by_id[_ser.serializer_id] = _ser
830+
_ser = MsgpackSerializer()
831+
_serializers["msgpack"] = _ser
832+
_serializers_by_id[_ser.serializer_id] = _ser
844833
except ImportError:
845834
pass
846835
del _ser

0 commit comments

Comments
 (0)