Expand RingBufferImplementation beyond shared_ptr and unique_ptr

Signed-off-by: Jeffery Hsu <[email protected]>

Author: jefferyyjhsu

rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp

@@ -198,11 +198,15 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
   /**
    * This member function is thread-safe.
    * Two versions for the implementation of the function.
-   * One for buffer containing unique_ptr and the other for other typess
+   * One for buffer containing unique_ptr and the other for other types
    *
    * \return a vector containing all the elements from the ring buffer
    */
-  template<typename T = BufferT, std::enable_if_t<is_std_unique_ptr<T>::value, void> * = nullptr>
+  template<typename T = BufferT, std::enable_if_t<is_std_unique_ptr<T>::value &&
+    std::is_copy_constructible<
+      typename is_std_unique_ptr<T>::Ptr_type
+    >::value,
+    void> * = nullptr>
   std::vector<BufferT> get_all_data_impl()
   {
     std::lock_guard<std::mutex> lock(mutex_);
@@ -216,7 +220,8 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
     return result_vtr;
   }
 
-  template<typename T = BufferT, std::enable_if_t<!is_std_unique_ptr<T>::value, void> * = nullptr>
+  template<typename T = BufferT, std::enable_if_t<
+      std::is_copy_constructible<T>::value, void> * = nullptr>
   std::vector<BufferT> get_all_data_impl()
   {
     std::lock_guard<std::mutex> lock(mutex_);
@@ -228,6 +233,23 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
     return result_vtr;
   }
 
+  template<typename T = BufferT, std::enable_if_t<!is_std_unique_ptr<T>::value &&
+    !std::is_copy_constructible<T>::value, void> * = nullptr>
+  std::vector<BufferT> get_all_data_impl()
+  {
+    throw std::logic_error("Underlined type results in invalid get_all_data_impl()");
+    return {};
+  }
+
+  template<typename T = BufferT, std::enable_if_t<is_std_unique_ptr<T>::value &&
+    !std::is_copy_constructible<typename is_std_unique_ptr<T>::Ptr_type>::value,
+    void> * = nullptr>
+  std::vector<BufferT> get_all_data_impl()
+  {
+    throw std::logic_error("Underlined type in unique_ptr results in invalid get_all_data_impl()");
+    return {};
+  }
+
   size_t capacity_;
 
   std::vector<BufferT> ring_buffer_;