Fix warning - copy elision

Mauro Passerino · Mauro Passerino · commit 3c412275bec9 · 2024-08-09T14:00:30.000+01:00
diff --git a/rclcpp/include/rclcpp/experimental/intra_process_manager.hpp b/rclcpp/include/rclcpp/experimental/intra_process_manager.hpp
@@ -1061,7 +1061,7 @@ class IntraProcessManager
           auto ptr = MessageAllocTraits::allocate(allocator, 1);
           MessageAllocTraits::construct(allocator, ptr, *message);
 
-          subscription->provide_intra_process_data(std::move(MessageUniquePtr(ptr, deleter)));
+          subscription->provide_intra_process_data(MessageUniquePtr(ptr, deleter));
         }
 
         continue;
@@ -1104,7 +1104,7 @@ class IntraProcessManager
             MessageAllocTraits::construct(allocator, ptr, *message);
 
             ros_message_subscription->provide_intra_process_message(
-              std::move(MessageUniquePtr(ptr, deleter)));
+              MessageUniquePtr(ptr, deleter));
           }
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -1061,7 +1061,7 @@ class IntraProcessManager`
`1061`	`1061`	`auto ptr = MessageAllocTraits::allocate(allocator, 1);`
`1062`	`1062`	`MessageAllocTraits::construct(allocator, ptr, *message);`
`1063`	`1063`
`1064`		`- subscription->provide_intra_process_data(std::move(MessageUniquePtr(ptr, deleter)));`
	`1064`	`+ subscription->provide_intra_process_data(MessageUniquePtr(ptr, deleter));`
`1065`	`1065`	`}`
`1066`	`1066`
`1067`	`1067`	`continue;`
`@@ -1104,7 +1104,7 @@ class IntraProcessManager`
`1104`	`1104`	`MessageAllocTraits::construct(allocator, ptr, *message);`
`1105`	`1105`
`1106`	`1106`	`ros_message_subscription->provide_intra_process_message(`
`1107`		`- std::move(MessageUniquePtr(ptr, deleter)));`
	`1107`	`+ MessageUniquePtr(ptr, deleter));`
`1108`	`1108`	`}`
`1109`	`1109`	`}`
`1110`	`1110`	`}`