fix typos and errors in comments

Signed-off-by: Alberto Soragna <[email protected]>

Author: alsora

rclcpp/include/rclcpp/client.hpp

@@ -173,7 +173,6 @@ class ClientBase
    * If you want more information available in the callback, like the client
    * or other information, you may use a lambda with captures or std::bind.
    *
-   * \sa rclcpp::ClientBase::clear_on_new_response_callback
    * \sa rmw_client_set_on_new_response_callback
    * \sa rcl_client_set_on_new_response_callback
    *

rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp

@@ -79,11 +79,11 @@ class SubscriptionIntraProcessBase : public rclcpp::Waitable
   rmw_qos_profile_t
   get_actual_qos() const;
 
-  /// Set a callback to be called when each new event instance occurs.
+  /// Set a callback to be called when each new message arrives.
   /**
-   * The callback receives a size_t which is the number of responses received
+   * The callback receives a size_t which is the number of messages received
    * since the last time this callback was called.
-   * Normally this is 1, but can be > 1 if responses were received before any
+   * Normally this is 1, but can be > 1 if messages were received before any
    * callback was set.
    *
    * The callback also receives an int identifier argument.
@@ -92,7 +92,7 @@ class SubscriptionIntraProcessBase : public rclcpp::Waitable
    * The application should provide a generic callback function that will be then
    * forwarded by the waitable to all of its entities.
    * Before forwarding, a different value for the identifier argument will be
-   * bounded to the function.
+   * bond to the function.
    * This implies that the provided callback can use the identifier to behave
    * differently depending on which entity triggered the waitable to become ready.
    *
@@ -102,14 +102,9 @@ class SubscriptionIntraProcessBase : public rclcpp::Waitable
    *
    * This function is thread-safe.
    *
-   * If you want more information available in the callback, like the client
+   * If you want more information available in the callback, like the subscription
    * or other information, you may use a lambda with captures or std::bind.
    *
-   * Note: this function must be overridden with a proper implementation
-   * by the custom classes who inherit from rclcpp::Waitable if they want to use it.
-   *
-   * \sa rclcpp::SubscriptionIntraProcessBase::clear_on_ready_callback
-   *
    * \param[in] callback functor to be called when a new message is received.
    */
   void

rclcpp/include/rclcpp/qos_event.hpp

@@ -113,9 +113,9 @@ class QOSEventHandlerBase : public Waitable
 
   /// Set a callback to be called when each new event instance occurs.
   /**
-   * The callback receives a size_t which is the number of responses received
+   * The callback receives a size_t which is the number of events that occurred
    * since the last time this callback was called.
-   * Normally this is 1, but can be > 1 if responses were received before any
+   * Normally this is 1, but can be > 1 if events occurred before any
    * callback was set.
    *
    * The callback also receives an int identifier argument.
@@ -124,7 +124,7 @@ class QOSEventHandlerBase : public Waitable
    * The application should provide a generic callback function that will be then
    * forwarded by the waitable to all of its entities.
    * Before forwarding, a different value for the identifier argument will be
-   * bounded to the function.
+   * bond to the function.
    * This implies that the provided callback can use the identifier to behave
    * differently depending on which entity triggered the waitable to become ready.
    *
@@ -139,13 +139,9 @@ class QOSEventHandlerBase : public Waitable
    *
    * This function is thread-safe.
    *
-   * If you want more information available in the callback, like the client
+   * If you want more information available in the callback, like the qos event
    * or other information, you may use a lambda with captures or std::bind.
    *
-   * Note: this function must be overridden with a proper implementation
-   * by the custom classes who inherit from rclcpp::Waitable if they want to use it.
-   *
-   * \sa rclcpp::QOSEventHandlerBase::clear_on_ready_callback
    * \sa rmw_event_set_callback
    * \sa rcl_event_set_callback
    *

rclcpp/include/rclcpp/service.hpp

@@ -148,13 +148,11 @@ class ServiceBase
    * If you want more information available in the callback, like the service
    * or other information, you may use a lambda with captures or std::bind.
    *
-   * \sa rclcpp::ServiceBase::clear_on_new_request_callback
    * \sa rmw_service_set_on_new_request_callback
    * \sa rcl_service_set_on_new_request_callback
    *
    * \param[in] callback functor to be called when a new request is received
    */
-  RCLCPP_PUBLIC
   void
   set_on_new_request_callback(std::function<void(size_t)> callback)
   {
@@ -203,7 +201,6 @@ class ServiceBase
   }
 
   /// Unset the callback registered for new requests, if any.
-  RCLCPP_PUBLIC
   void
   clear_on_new_request_callback()
   {

rclcpp/include/rclcpp/waitable.hpp

@@ -217,7 +217,7 @@ class Waitable
    * The application should provide a generic callback function that will be then
    * forwarded by the waitable to all of its entities.
    * Before forwarding, a different value for the identifier argument will be
-   * bounded to the function.
+   * bond to the function.
    * This implies that the provided callback can use the identifier to behave
    * differently depending on which entity triggered the waitable to become ready.
    *