Skip to content

Commit 5780ccf

Browse files
author
Mauro Passerino
committed
Set size limit in constructor
1 parent 0317e77 commit 5780ccf

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

rclcpp/include/rclcpp/experimental/buffers/bounded_events_queue.hpp

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@ namespace buffers
3636
class BoundedEventsQueue : public EventsQueue
3737
{
3838
public:
39+
RCLCPP_PUBLIC
40+
explicit BoundedEventsQueue(size_t queue_size_limit)
41+
{
42+
queue_size_limit_ = queue_size_limit;
43+
}
44+
3945
RCLCPP_PUBLIC
4046
~BoundedEventsQueue() = default;
4147

@@ -121,21 +127,9 @@ class BoundedEventsQueue : public EventsQueue
121127
return local_queue;
122128
}
123129

124-
/**
125-
* @brief sets the queue size limit
126-
* @param limit The queue size limit
127-
*/
128-
RCLCPP_PUBLIC
129-
void
130-
set_queue_size_limit(size_t queue_size_limit)
131-
{
132-
queue_size_limit_ = queue_size_limit;
133-
}
134-
135130
private:
136131
std::queue<rmw_listener_event_t> event_queue_;
137-
138-
size_t queue_size_limit_ = 1000;
132+
size_t queue_size_limit_;
139133
};
140134

141135
} // namespace buffers

rclcpp/test/rclcpp/executors/test_events_queue.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ class TestEventsQueue : public ::testing::Test
4141
TEST_F(TestEventsQueue, BoundedQueue)
4242
{
4343
// Create BoundedEventsQueue and set limit to 10 events.
44-
auto bounded_queue = std::make_unique<rclcpp::experimental::buffers::BoundedEventsQueue>();
45-
bounded_queue->set_queue_size_limit(10);
44+
auto bounded_queue = std::make_unique<rclcpp::experimental::buffers::BoundedEventsQueue>(10);
4645

4746
// Create an events executor using the bounded queue
4847
EventsExecutor executor_sub(std::move(bounded_queue));

0 commit comments

Comments
 (0)