Skip to content

Commit 6328325

Browse files
alsoraskyegalaxy
authored andcommitted
correct template syntax
Signed-off-by: Alberto Soragna <[email protected]> (cherry picked from commit d4dd4e4)
1 parent 834de49 commit 6328325

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

rclcpp/include/rclcpp/client.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ class Client : public ClientBase
908908
// the server might be available in another process or was configured to not use IPC.
909909
if (intra_process_server_available) {
910910
// Send intra-process request
911-
ipm->send_intra_process_client_request<ServiceT>(
911+
ipm->template send_intra_process_client_request<ServiceT>(
912912
intra_process_client_id_,
913913
std::make_pair(std::move(request), std::move(value)));
914914
return ipc_sequence_number_++;

rclcpp_action/include/rclcpp_action/client.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ class Client : public ClientBase
526526
ipc_action_client_->store_goal_response_callback(
527527
hashed_guuid, goal_response_callback);
528528

529-
intra_process_send_done = ipm->intra_process_action_send_goal_request<ActionT>(
529+
intra_process_send_done = ipm->template intra_process_action_send_goal_request<ActionT>(
530530
ipc_action_client_id_,
531531
std::move(goal_request),
532532
hashed_guuid);
@@ -905,7 +905,7 @@ class Client : public ClientBase
905905
ipc_action_client_->store_result_response_callback(
906906
hashed_guuid, result_response_callback);
907907

908-
intra_process_send_done = ipm->intra_process_action_send_result_request<ActionT>(
908+
intra_process_send_done = ipm->template intra_process_action_send_result_request<ActionT>(
909909
ipc_action_client_id_,
910910
std::move(goal_result_request));
911911
}
@@ -961,7 +961,7 @@ class Client : public ClientBase
961961
ipc_action_client_->store_cancel_goal_callback(
962962
hashed_guuid, cancel_goal_callback);
963963

964-
intra_process_send_done = ipm->intra_process_action_send_cancel_request<ActionT>(
964+
intra_process_send_done = ipm->template intra_process_action_send_cancel_request<ActionT>(
965965
ipc_action_client_id_,
966966
std::move(cancel_request));
967967
}

rclcpp_action/include/rclcpp_action/server.hpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -521,11 +521,7 @@ class Server : public ServerBase, public std::enable_shared_from_this<Server<Act
521521

522522
auto ipm = lock_intra_process_manager();
523523

524-
// Here we store the uuid of the goal and associate it with a client
525-
// so we can retrieve it when response is ready, or when sending feedback
526-
// since the feedback calls only provide the goal UUID
527-
// Store an entry
528-
ipm->store_intra_process_action_client_goal_uuid(
524+
ipm->template intra_process_action_send_goal_response<ActionT>(
529525
intra_process_action_client_id,
530526
std::hash<GoalUUID>()(uuid));
531527

@@ -598,7 +594,9 @@ class Server : public ServerBase, public std::enable_shared_from_this<Server<Act
598594
std::move(status_msg));
599595
}
600596

601-
ipm->intra_process_action_send_cancel_response<ActionT>(
597+
GoalUUID uuid = request->goal_info.goal_id.uuid;
598+
599+
ipm->template intra_process_action_send_cancel_response<ActionT>(
602600
intra_process_action_client_id,
603601
std::move(response));
604602
}
@@ -632,8 +630,8 @@ class Server : public ServerBase, public std::enable_shared_from_this<Server<Act
632630
"after destruction of intra process manager");
633631
}
634632

635-
auto typed_response = std::static_pointer_cast<ResultResponse>(result_response);
636-
ipm->intra_process_action_send_result_response<ActionT>(
633+
634+
ipm->template intra_process_action_send_result_response<ActionT>(
637635
intra_process_action_client_id,
638636
std::move(typed_response));
639637
}

0 commit comments

Comments
 (0)