Skip to content

Commit 6ef29c1

Browse files
author
Mauro Passerino
committed
Remove const on set_listener_callback
Signed-off-by: Mauro Passerino <[email protected]>
1 parent 56405fc commit 6ef29c1

File tree

8 files changed

+32
-4
lines changed

8 files changed

+32
-4
lines changed

rclcpp/include/rclcpp/executors/events_executor_notify_waitable.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class EventsExecutorNotifyWaitable final : public EventWaitable
6262
void
6363
set_listener_callback(
6464
rmw_listener_callback_t callback,
65-
const void * user_data) const override
65+
const void * user_data) override
6666
{
6767
for (auto gc : notify_guard_conditions_) {
6868
// gc->set_listener_callback();

rclcpp/include/rclcpp/experimental/subscription_intra_process_base.hpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,12 @@ class SubscriptionIntraProcessBase : public rclcpp::Waitable
7777
rmw_qos_profile_t
7878
get_actual_qos() const;
7979

80+
RCLCPP_PUBLIC
81+
void
82+
set_listener_callback(
83+
rmw_listener_callback_t callback,
84+
const void * user_data) override;
85+
8086
protected:
8187
std::recursive_mutex reentrant_mutex_;
8288
rclcpp::GuardCondition gc_;

rclcpp/include/rclcpp/qos_event.hpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,12 @@ class QOSEventHandlerBase : public Waitable
169169
static_cast<const void *>(&on_new_event_callback_));
170170
}
171171

172+
RCLCPP_PUBLIC
173+
void
174+
set_listener_callback(
175+
rmw_listener_callback_t callback,
176+
const void * user_data) override;
177+
172178
protected:
173179
RCLCPP_PUBLIC
174180
void

rclcpp/include/rclcpp/waitable.hpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,13 @@ class Waitable
203203
bool
204204
exchange_in_use_by_wait_set_state(bool in_use_state);
205205

206+
RCLCPP_PUBLIC
207+
virtual
208+
void
209+
set_listener_callback(
210+
rmw_listener_callback_t callback,
211+
const void * user_data);
212+
206213
private:
207214
std::atomic<bool> in_use_by_wait_set_{false};
208215
}; // class Waitable

rclcpp/src/rclcpp/qos_event.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,13 @@ QOSEventHandlerBase::set_on_new_event_callback(
8484
}
8585
}
8686

87+
void
88+
QOSEventHandlerBase::set_listener_callback(
89+
rmw_listener_callback_t callback,
90+
const void * user_data)
91+
{
92+
set_on_new_event_callback(callback, user_data);
93+
}
94+
95+
8796
} // namespace rclcpp

rclcpp/src/rclcpp/subscription_intra_process_base.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ SubscriptionIntraProcessBase::get_actual_qos() const
4141
void
4242
SubscriptionIntraProcessBase::set_listener_callback(
4343
rmw_listener_callback_t callback,
44-
const void * user_data) const
44+
const void * user_data)
4545
{
4646
(void)callback;
4747
(void)user_data;

rclcpp/src/rclcpp/waitable.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Waitable::exchange_in_use_by_wait_set_state(bool in_use_state)
6363
void
6464
Waitable::set_listener_callback(
6565
rmw_listener_callback_t callback,
66-
const void * user_data) const
66+
const void * user_data)
6767
{
6868
(void)callback;
6969
(void)user_data;

rclcpp/test/rclcpp/executors/test_executors.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ class TestWaitable : public rclcpp::Waitable
449449
void
450450
set_listener_callback(
451451
rmw_listener_callback_t callback,
452-
const void * user_data) const override
452+
const void * user_data) override
453453
{
454454
rcl_ret_t ret = rcl_guard_condition_set_listener_callback(
455455
&gc_, callback, user_data);

0 commit comments

Comments
 (0)