Fixes for Clang builds

Author: Mauro Passerino

rclcpp/include/rclcpp/experimental/action_client_intra_process.hpp

@@ -182,7 +182,7 @@ class ActionClientIntraProcess : public ActionClientIntraProcessBase
       auto data = std::move(feedback_buffer_->consume());
       return std::static_pointer_cast<void>(data);
     } else if (is_status_ready_) {
-      auto data = std::move(status_buffer_->consume());
+      auto data = status_buffer_->consume();
       return std::static_pointer_cast<void>(data);
     } else {
       throw std::runtime_error("Taking data from intra-process action client but nothing is ready");

rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp

@@ -62,7 +62,7 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
    *
    * \param request the element to be stored in the ring buffer
    */
-  void enqueue(BufferT request)
+  void enqueue(BufferT request) override
   {
     std::lock_guard<std::mutex> lock(mutex_);
 
@@ -82,7 +82,7 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
    *
    * \return the element that is being removed from the ring buffer
    */
-  BufferT dequeue()
+  BufferT dequeue() override
   {
     std::lock_guard<std::mutex> lock(mutex_);
 
@@ -128,7 +128,7 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
    *
    * \return `true` if there is data and `false` otherwise
    */
-  inline bool has_data() const
+  inline bool has_data() const override
   {
     std::lock_guard<std::mutex> lock(mutex_);
     return has_data_();
@@ -147,7 +147,7 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
     return is_full_();
   }
 
-  void clear() {}
+  void clear() override {}
 
 private:
   /// Get the next index value for the ring buffer

rclcpp/include/rclcpp/experimental/client_intra_process.hpp

@@ -76,7 +76,7 @@ class ClientIntraProcess : public ClientIntraProcessBase
   virtual ~ClientIntraProcess() = default;
 
   bool
-  is_ready(rcl_wait_set_t * wait_set)
+  is_ready(rcl_wait_set_t * wait_set) override
   {
     (void) wait_set;
     return buffer_->has_data();
@@ -97,7 +97,7 @@ class ClientIntraProcess : public ClientIntraProcessBase
     return std::static_pointer_cast<void>(data);
   }
 
-  void execute(std::shared_ptr<void> & data)
+  void execute(std::shared_ptr<void> & data) override
   {
     if (!data) {
       throw std::runtime_error("'data' is empty");