Skip to content

Commit f165a25

Browse files
jmachowinskiJanosch Machowinskiwjwwood
authored andcommitted
fix: Fixed race condition in action server between is_ready and take"… (ros2#2531)
* fix: Fixed race condition in action server between is_ready and take" (ros2#2495) Some background information: is_ready, take_data and execute data may be called from different threads in any order. The code in the old state expected them to be called in series, without interruption. This lead to multiple race conditions, as the state of the pimpl objects was altered by the three functions in a non thread safe way. Co-authored-by: William Woodall <[email protected]> Signed-off-by: Janosch Machowinski <[email protected]> * fix: added workaround for call to double calls to take_data This adds a workaround for a known bug in the executor in iron. Signed-off-by: Janosch Machowinski <[email protected]> --------- Signed-off-by: Janosch Machowinski <[email protected]> Co-authored-by: Janosch Machowinski <[email protected]> Co-authored-by: William Woodall <[email protected]>
1 parent 25fac83 commit f165a25

File tree

2 files changed

+566
-243
lines changed

2 files changed

+566
-243
lines changed

0 commit comments

Comments
 (0)