Fix cppcheck

Mauro Passerino · Mauro Passerino · commit f3fa8cbd4ae6 · 2021-01-19T14:22:10.000-03:00
error: deallocuse - Dereferencing 'node_ptr' after
it is deallocated / released

Seems that:
NodeBaseInterface::WeakPtr node_weak_ptr(node_ptr);
causes the cppcheck to fail if node_ptr is used after creating
the weak pointer from it.
diff --git a/rclcpp/src/rclcpp/executors/events_executor_entities_collector.cpp b/rclcpp/src/rclcpp/executors/events_executor_entities_collector.cpp
@@ -142,8 +142,7 @@ EventsExecutorEntitiesCollector::add_callback_group(
     set_guard_condition_callback(node_ptr->get_notify_guard_condition());
 
     // Store node's notify guard condition
-    rclcpp::node_interfaces::NodeBaseInterface::WeakPtr node_weak_ptr(node_ptr);
-    weak_nodes_to_guard_conditions_[node_weak_ptr] = node_ptr->get_notify_guard_condition();
+    weak_nodes_to_guard_conditions_[node_ptr] = node_ptr->get_notify_guard_condition();
   }
 
   // Add callback group to weak_groups_to_node

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,7 @@ EventsExecutorEntitiesCollector::add_callback_group(`
`142`	`142`	`set_guard_condition_callback(node_ptr->get_notify_guard_condition());`
`143`	`143`
`144`	`144`	`// Store node's notify guard condition`
`145`		`- rclcpp::node_interfaces::NodeBaseInterface::WeakPtr node_weak_ptr(node_ptr);`
`146`		`- weak_nodes_to_guard_conditions_[node_weak_ptr] = node_ptr->get_notify_guard_condition();`
	`145`	`+ weak_nodes_to_guard_conditions_[node_ptr] = node_ptr->get_notify_guard_condition();`
`147`	`146`	`}`
`148`	`147`
`149`	`148`	`// Add callback group to weak_groups_to_node`